Convert Panner tests to new Audit

Convert Panner tests to new Audit

Manually convert tests to use new Audit

BUG=704967
TEST=
Panner/panner-automation-basic.html
Panner/panner-automation-position.html
Panner/panner-distance-clamping.html
Panner/panner-rolloff-clamping.html
Panner/pannernode-basic.html

Review-Url: https://codereview.chromium.org/2799793003
Cr-Commit-Position: refs/heads/master@{#469520}
Committed: https://chromium.googlesource.com/chromium/src/+/428cd3be8169a04c94c7ac1e0cf18f3789c4935f

[Raymond Toy, 2017-05-01 15:19:24]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-05-01 15:19:25]

PTAL

[hongchan, 2017-05-02 16:46:31]

I don't think we need the 'success' variable any more. Please scan and remove
them.

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html
(right):

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html:126:
verifyPannerOutputChanged(should, resultBuffer, {
Is this done by clang-format? Why is the indentation so deep?

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html:241:
should(data0.slice(0, suspendFrame),
Please revise the indentation of this area.

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html:250:
should(data0.slice(suspendFrame),
Ditto.

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html
(right):

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html:27: var
success = true;
We don't need this 'success' variable any more. Right?

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html:85: var
success = true;
No 'success' is needed.

[Raymond Toy, 2017-05-02 19:04:29]

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html
(right):

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html:126:
verifyPannerOutputChanged(should, resultBuffer, {
On 2017/05/02 16:46:31, hongchan wrote:
> Is this done by clang-format? Why is the indentation so deep?

Reindented everything with clang-format.

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html
(right):

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html:27: var
success = true;
On 2017/05/02 16:46:31, hongchan wrote:
> We don't need this 'success' variable any more. Right?

Done.

https://codereview.chromium.org/2799793003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/pannernode-basic.html:85: var
success = true;
On 2017/05/02 16:46:31, hongchan wrote:
> No 'success' is needed.

Done.

[hongchan, 2017-05-03 15:46:57]

Everything looks good except for the line 60. What happened there?

https://codereview.chromium.org/2799793003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html
(right):

https://codereview.chromium.org/2799793003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html:60:
audit.define('Stereo panner.' + config.setter, tester(config, 2));
Hmm. This is really weird.

[Raymond Toy, 2017-05-03 16:33:21]

https://codereview.chromium.org/2799793003/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html
(right):

https://codereview.chromium.org/2799793003/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/webaudio/Panner/panner-automation-basic.html:60:
audit.define('Stereo panner.' + config.setter, tester(config, 2));
On 2017/05/03 15:46:57, hongchan wrote:
> Hmm. This is really weird.

clang-format gets confused if the preceeding line is missing an ending
semicolon.

clang-formatted the entire file again, fixing another indentation mistake at
line 44-45.

[hongchan, 2017-05-04 19:42:05]

lgtm

[Raymond Toy, 2017-05-04 19:42:37]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-05-04 19:42:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 20:55:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 20:55:10]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raymond Toy, 2017-05-04 22:00:05]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-05-04 22:00:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2799793003/#ps100001
(title: "Add back some test features")

[commit-bot: I haz the power, 2017-05-04 22:00:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 23:32:41]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1493935205819360,
"parent_rev": "78cbcd5cd4e8022b18067c522e66f2fa1d02ba8b", "commit_rev":
"428cd3be8169a04c94c7ac1e0cf18f3789c4935f"}

[commit-bot: I haz the power, 2017-05-04 23:35:04]

Description was changed from

==========
Convert Panner tests to new Audit

Manually convert tests to use new Audit

BUG=704967
TEST=
Panner/panner-automation-basic.html
Panner/panner-automation-position.html
Panner/panner-distance-clamping.html
Panner/panner-rolloff-clamping.html
Panner/pannernode-basic.html
==========

to

==========
Convert Panner tests to new Audit

Manually convert tests to use new Audit

BUG=704967
TEST=
Panner/panner-automation-basic.html
Panner/panner-automation-position.html
Panner/panner-distance-clamping.html
Panner/panner-rolloff-clamping.html
Panner/pannernode-basic.html

Review-Url: https://codereview.chromium.org/2799793003
Cr-Commit-Position: refs/heads/master@{#469520}
Committed:
https://chromium.googlesource.com/chromium/src/+/428cd3be8169a04c94c7ac1e0cf1...
==========

[commit-bot: I haz the power, 2017-05-04 23:35:05]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/428cd3be8169a04c94c7ac1e0cf1...