Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2799783007: [Sync] Fix TwoClientAppListSyncTest.Move (Closed)

Created:
3 years, 8 months ago by Gang Wu
Modified:
3 years, 8 months ago
Reviewers:
skym
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Fix TwoClientAppListSyncTest.Move After sync, the test did not install pending apps on the synced client. BUG=689662 Review-Url: https://codereview.chromium.org/2799783007 Cr-Commit-Position: refs/heads/master@{#463000} Committed: https://chromium.googlesource.com/chromium/src/+/03a0356e4e8839701627209ce25c0edaeca3a10f

Patch Set 1 : refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -43 lines) Patch
M chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc View 14 chunks +22 lines, -43 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
Gang Wu
PTAL
3 years, 8 months ago (2017-04-07 20:22:18 UTC) #8
skym
lgtm
3 years, 8 months ago (2017-04-07 20:49:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799783007/20001
3 years, 8 months ago (2017-04-07 20:50:35 UTC) #13
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 21:36:12 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/03a0356e4e8839701627209ce25c...

Powered by Google App Engine
This is Rietveld 408576698