Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2799783002: Add automated VR latency tester (Closed)

Created:
3 years, 8 months ago by bsheedy
Modified:
3 years, 8 months ago
Reviewers:
Nico, Lei Lei
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add automated VR latency tester Adds a script to automatically measure the motion-to-photon/app latency for VR. This requires specialized hardware to measure the latency and move the device during the test, so it is only meant to be run on our swarming bot that has been set up to work with it. Has not yet been set up to run continuously, but currently works if manually triggered to run on our bot, so can be useful for teammates that do not have the necessary hardware to measure latency themselves. BUG=708747 Review-Url: https://codereview.chromium.org/2799783002 Cr-Commit-Position: refs/heads/master@{#464230} Committed: https://chromium.googlesource.com/chromium/src/+/84541d55d66a59f8b44afaad69882beb10de265b

Patch Set 1 #

Patch Set 2 : Add support for args #

Patch Set 3 : Working version that must be manually triggered #

Total comments: 26

Patch Set 4 : Address leilei@ comments #

Total comments: 4

Patch Set 5 : Address thakis@ comments #

Total comments: 6

Patch Set 6 : Rebase + address final comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -1 line) Patch
M BUILD.gn View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
A chrome/test/vr/perf/latency/BUILD.gn View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
A chrome/test/vr/perf/latency/run_latency_test.py View 1 2 3 4 5 1 chunk +283 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
M testing/buildbot/manage.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
bsheedy
+thakis for OWNERS +leilei for someone who's familiar with VR testing and swarming
3 years, 8 months ago (2017-04-07 16:57:59 UTC) #3
Lei Lei
https://codereview.chromium.org/2799783002/diff/40001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2799783002/diff/40001/BUILD.gn#newcode701 BUILD.gn:701: "//chrome/test/vr/automated_motopho_latency:automated_motopho_latency_test", Why do you add automated_motopho_latency_test target to gn_all ...
3 years, 8 months ago (2017-04-07 21:36:35 UTC) #6
bsheedy
https://codereview.chromium.org/2799783002/diff/40001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2799783002/diff/40001/BUILD.gn#newcode701 BUILD.gn:701: "//chrome/test/vr/automated_motopho_latency:automated_motopho_latency_test", On 2017/04/07 21:36:34, Lei Lei wrote: > Why ...
3 years, 8 months ago (2017-04-07 23:24:52 UTC) #7
Nico
chrome/ kind of feels like the wrong place for this. kbr, does this type of ...
3 years, 8 months ago (2017-04-10 18:41:28 UTC) #8
bsheedy
https://codereview.chromium.org/2799783002/diff/60001/chrome/test/vr/perf/latency/run_latency_test.py File chrome/test/vr/perf/latency/run_latency_test.py (right): https://codereview.chromium.org/2799783002/diff/60001/chrome/test/vr/perf/latency/run_latency_test.py#newcode33 chrome/test/vr/perf/latency/run_latency_test.py:33: DEFAULT_MOTOPHO_PATH = '/home/gtvchrome/motopho/Motopho' On 2017/04/10 18:41:28, Nico wrote: > ...
3 years, 8 months ago (2017-04-10 22:36:15 UTC) #9
Ken Russell (switch to Gerrit)
On 2017/04/10 18:41:28, Nico wrote: > chrome/ kind of feels like the wrong place for ...
3 years, 8 months ago (2017-04-10 23:38:12 UTC) #10
Nico
lgtm once leilei is happy. I didn't look at the main python script much, I'm ...
3 years, 8 months ago (2017-04-11 15:48:34 UTC) #11
Lei Lei
lgtm https://codereview.chromium.org/2799783002/diff/80001/chrome/test/vr/perf/latency/run_latency_test.py File chrome/test/vr/perf/latency/run_latency_test.py (right): https://codereview.chromium.org/2799783002/diff/80001/chrome/test/vr/perf/latency/run_latency_test.py#newcode46 chrome/test/vr/perf/latency/run_latency_test.py:46: def run(self): s/run/Run to keep consistent within file. ...
3 years, 8 months ago (2017-04-12 22:10:53 UTC) #12
bsheedy
https://codereview.chromium.org/2799783002/diff/80001/chrome/test/vr/perf/latency/run_latency_test.py File chrome/test/vr/perf/latency/run_latency_test.py (right): https://codereview.chromium.org/2799783002/diff/80001/chrome/test/vr/perf/latency/run_latency_test.py#newcode46 chrome/test/vr/perf/latency/run_latency_test.py:46: def run(self): On 2017/04/12 22:10:53, Lei Lei wrote: > ...
3 years, 8 months ago (2017-04-12 22:51:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799783002/100001
3 years, 8 months ago (2017-04-12 22:52:47 UTC) #16
commit-bot: I haz the power
3 years, 8 months ago (2017-04-13 01:25:38 UTC) #19
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/84541d55d66a59f8b44afaad6988...

Powered by Google App Engine
This is Rietveld 408576698