Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2799763003: Fix for type analysis bug in constructor with early return (Closed)

Created:
3 years, 8 months ago by sra1
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org, Harry Terkelsen
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for type analysis bug in constructor with early return TEST_28 is isomorphic to the original report. BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/fe7baee84828e109a49920c2572f3917e5ff8ca5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -12 lines) Patch
M pkg/compiler/lib/src/inferrer/builder.dart View 3 chunks +8 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/locals_handler.dart View 3 chunks +22 lines, -11 lines 0 comments Download
M tests/compiler/dart2js/field_type_simple_inferer_test.dart View 3 chunks +71 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
3 years, 8 months ago (2017-04-06 00:27:30 UTC) #2
Emily Fortuna
lgtm!
3 years, 8 months ago (2017-04-06 00:31:07 UTC) #3
sra1
3 years, 8 months ago (2017-04-06 16:11:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fe7baee84828e109a49920c2572f3917e5ff8ca5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698