Fix for type analysis bug in constructor with early return

pkg/compiler/lib/src/inferrer/builder.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library simple_types_inferrer;
 
 import '../closure.dart' show ClosureClassMap;
 import '../common.dart';
 import '../common/names.dart' show Identifiers, Selectors;
 import '../compiler.dart' show Compiler;
@@ skipping 113 matching lines @@
         ? locals.fieldScope.isThisExposed
         : true;
   }
 
   void set isThisExposed(value) {
     if (analyzedElement.isGenerativeConstructor) {
       locals.fieldScope.isThisExposed = value;
     }
   }
 
+  void initializationIsIndefinite() {
+    if (analyzedElement.isGenerativeConstructor) {
+      locals.fieldScope.isIndefinite = true;
+    }
+  }
+
   DiagnosticReporter get reporter => compiler.reporter;
 
   ClosedWorld get closedWorld => inferrer.closedWorld;
 
   @override
   SemanticSendVisitor get sendVisitor => this;
 
   @override
   TypeInformation apply(ast.Node node, _) => visit(node);
 
@@ skipping 559 matching lines @@
       handleCondition(node.condition, tests);
       updateIsChecks(tests, usePositive: true);
       visit(node.body);
       visit(node.update);
     });
   }
 
   TypeInformation visitTryStatement(ast.TryStatement node) {
     LocalsHandler saved = locals;
     locals = new LocalsHandler.from(locals, node, useOtherTryBlock: false);
+    initializationIsIndefinite();
     visit(node.tryBlock);
     saved.mergeDiamondFlow(locals, null);
     locals = saved;
     for (ast.Node catchBlock in node.catchBlocks) {
       saved = locals;
       locals = new LocalsHandler.from(locals, catchBlock);
       visit(catchBlock);
       saved.mergeDiamondFlow(locals, null);
       locals = saved;
     }
@@ skipping 2133 matching lines @@
     }
     locals.seenReturnOrThrow = true;
     return null;
   }
 
   TypeInformation visitReturn(ast.Return node) {
     ast.Node expression = node.expression;
     recordReturnType(
         expression == null ? types.nullType : expression.accept(this));
     locals.seenReturnOrThrow = true;
+    initializationIsIndefinite();
     return null;
   }
 
   TypeInformation handleForInLoop(
       ast.ForIn node,
       TypeInformation iteratorType,
       Selector currentSelector,
       TypeMask currentMask,
       Selector moveNextSelector,
       TypeMask moveNextMask) {
@@ skipping 55 matching lines @@
     Selector moveNextSelector = Selectors.moveNext;
     TypeMask moveNextMask = inTreeData.typeOfIteratorMoveNext(node);
 
     TypeInformation iteratorType = handleDynamicSend(node, iteratorSelector,
         iteratorMask, expressionType, new ArgumentsTypes.empty());
 
     return handleForInLoop(node, iteratorType, currentSelector, currentMask,
         moveNextSelector, moveNextMask);
   }
 }