Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2799763002: Convert Convolver tests to new Audit (Closed)

Created:
3 years, 8 months ago by Raymond Toy
Modified:
3 years, 8 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Convolver tests to new Audit Manually convert tests to use new Audit BUG=704967 TEST=Convolver/convolver-channels.html Review-Url: https://codereview.chromium.org/2799763002 Cr-Commit-Position: refs/heads/master@{#463077} Committed: https://chromium.googlesource.com/chromium/src/+/46a8c1980ada358234a339dc009954b8c9abfe6a

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html View 1 3 chunks +8 lines, -17 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Raymond Toy
PTAL
3 years, 8 months ago (2017-04-07 22:23:36 UTC) #2
hongchan
lgtm with nit https://codereview.chromium.org/2799763002/diff/1/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html File third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html (right): https://codereview.chromium.org/2799763002/diff/1/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html#newcode31 third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html:31: }, message).notThrow(); nit: this could be ...
3 years, 8 months ago (2017-04-07 22:26:45 UTC) #3
Raymond Toy
https://codereview.chromium.org/2799763002/diff/1/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html File third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html (right): https://codereview.chromium.org/2799763002/diff/1/third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html#newcode31 third_party/WebKit/LayoutTests/webaudio/Convolver/convolver-channels.html:31: }, message).notThrow(); On 2017/04/07 22:26:45, hongchan wrote: > nit: ...
3 years, 8 months ago (2017-04-07 22:44:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799763002/20001
3 years, 8 months ago (2017-04-07 22:45:04 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-08 00:39:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/46a8c1980ada358234a339dc0099...

Powered by Google App Engine
This is Rietveld 408576698