Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2799753003: [wasm] Fix typing of loop labels in br_table (Closed)

Created:
3 years, 8 months ago by rossberg
Modified:
3 years, 8 months ago
Reviewers:
ahaas
CC:
v8-reviews_googlegroups.com, wasm-v8_google.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix typing of loop labels in br_table R=ahaas@chromium.org BUG=v8:6204 Review-Url: https://codereview.chromium.org/2799753003 Cr-Commit-Position: refs/heads/master@{#44435} Committed: https://chromium.googlesource.com/v8/v8/+/0344b73e66feaf809660120daf5fb9cd7e351607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M src/wasm/function-body-decoder.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
rossberg
3 years, 8 months ago (2017-04-06 09:56:31 UTC) #1
ahaas
lgtm
3 years, 8 months ago (2017-04-06 09:59:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799753003/1
3 years, 8 months ago (2017-04-06 10:00:27 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 10:26:02 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/0344b73e66feaf809660120daf5fb9cd7e3...

Powered by Google App Engine
This is Rietveld 408576698