Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2799743009: [Cronet] Get Cronet's javaperftest running again (Closed)

Created:
3 years, 8 months ago by pauljensen
Modified:
3 years, 8 months ago
Reviewers:
mef
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cronet] Get Cronet's javaperftest running again Some small changes: 1. Document some prerequisites for running the script. 2. Disable the OverrideDns() portion of the reverse tethering script as it hasn't worked in years, aborts the script, and isn't necessary. 3. Rename quic_server option as per crrev.com/2532083005 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester Review-Url: https://codereview.chromium.org/2799743009 Cr-Commit-Position: refs/heads/master@{#462993} Committed: https://chromium.googlesource.com/chromium/src/+/ca04ccfe0a0ef5e4026897735b8ac0a9d92c81a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M components/cronet/android/test/javaperftests/android_rndis_forwarder.py View 1 chunk +3 lines, -1 line 0 comments Download
M components/cronet/android/test/javaperftests/run.py View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
pauljensen
Misha, PTAL, thank you!
3 years, 8 months ago (2017-04-07 19:49:00 UTC) #3
mef
lgtm
3 years, 8 months ago (2017-04-07 19:52:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799743009/1
3 years, 8 months ago (2017-04-07 19:53:58 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 20:41:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ca04ccfe0a0ef5e4026897735b8a...

Powered by Google App Engine
This is Rietveld 408576698