Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2799743007: Remove geolocation-api/success-clear-watch.html test from ASAN exceptions file. (Closed)

Created:
3 years, 8 months ago by dougt
Modified:
3 years, 8 months ago
Reviewers:
brettw, mcasas
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove geolocation-api/success-clear-watch.html test from ASAN exceptions file. In Jan 20015, this test case on a ASAN run caused timeouts. An exception was added and life moved on. Re-running this tests locally does not appear to cause any timeout, and so we're going to re-enable the exception to see if there still exists a problem. BUG=446661 Review-Url: https://codereview.chromium.org/2799743007 Cr-Commit-Position: refs/heads/master@{#462945} Committed: https://chromium.googlesource.com/chromium/src/+/b726dba11c90d226f70c9dae4de30c002c066131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/ASANExpectations View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
dougt
Brett, please take a look. Note that this *might* case ASAN flakiness. If it does, ...
3 years, 8 months ago (2017-04-07 18:45:16 UTC) #6
mcasas
On 2017/04/07 18:45:16, dougt wrote: > Brett, please take a look. Note that this *might* ...
3 years, 8 months ago (2017-04-07 18:49:24 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799743007/1
3 years, 8 months ago (2017-04-07 18:51:33 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 18:58:20 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b726dba11c90d226f70c9dae4de3...

Powered by Google App Engine
This is Rietveld 408576698