[CrOS Tether] Add FakeCryptAuthService, a test double for CryptAuthService.

[CrOS Tether] Add FakeCryptAuthService, a test double for CryptAuthService.

BUG=672263
Review-Url: https://codereview.chromium.org/2799683004
Cr-Commit-Position: refs/heads/master@{#462637}
Committed: https://chromium.googlesource.com/chromium/src/+/0371cd7b822641355ec9fa5977070e73af2210cc

[Kyle Horimoto, 2017-04-05 23:23:07]

khorimoto@chromium.org changed reviewers:
+ hansberry@chromium.org, tengs@chromium.org

[Kyle Horimoto, 2017-04-06 01:02:02]

Description was changed from

==========
[CrOS Tether] CryptAuthService: Add two extra functions which are needed:
GetPrefs() and GetBluetoothThrottler().

This CL also:
(1) Updates call sites where BluetoothThrottler instances are used
(2) Adds a test double for CryptAuthService.

BUG=672263
==========

to

==========
[CrOS Tether] Add FakeCryptAuthService, a test double for CryptAuthService.

BUG=672263
==========

[Ryan Hansberry, 2017-04-06 15:18:25]

It seems you originally intended to add two extra methods on CryptAuthService;
why did you decide not to? Please update the CL description to reflect the final
choice.

https://codereview.chromium.org/2799683004/diff/60001/components/cryptauth/cr...
File components/cryptauth/cryptauth_service.h (right):

https://codereview.chromium.org/2799683004/diff/60001/components/cryptauth/cr...
components/cryptauth/cryptauth_service.h:8: #include <memory>
Is this necessary?

[Kyle Horimoto, 2017-04-06 16:51:34]

khorimoto@chromium.org changed reviewers:
- tengs@chromium.org

[Kyle Horimoto, 2017-04-06 16:51:34]

I removed the extra stuff in this CL because Tim didn't think it was a good idea
to add explicit dependencies to Bluetooth stuff in the CryptAuthService, since
it isn't necessarily related to CryptAuth. I'll come up with another approach
instead.

https://codereview.chromium.org/2799683004/diff/60001/components/cryptauth/cr...
File components/cryptauth/cryptauth_service.h (right):

https://codereview.chromium.org/2799683004/diff/60001/components/cryptauth/cr...
components/cryptauth/cryptauth_service.h:8: #include <memory>
On 2017/04/06 15:18:25, Ryan Hansberry wrote:
> Is this necessary?

For some reason, it wasn't compiling without this. Not sure why it didn't happen
before. But, it seems to make sense, since I'm using a std::unique_ptr.

[Ryan Hansberry, 2017-04-06 16:52:32]

The CQ bit was checked by hansberry@chromium.org

[Ryan Hansberry, 2017-04-06 16:52:32]

lgtm

[commit-bot: I haz the power, 2017-04-06 16:53:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 16:53:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 16:53:15]

No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Jeremy Klein, 2017-04-06 17:10:07]

jlklein@chromium.org changed reviewers:
+ jlklein@chromium.org

[Jeremy Klein, 2017-04-06 17:10:07]

lgtm

[Kyle Horimoto, 2017-04-06 17:11:08]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-04-06 17:11:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 17:53:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-06 17:53:30]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[Kyle Horimoto, 2017-04-06 20:29:56]

The CQ bit was checked by khorimoto@chromium.org

[Kyle Horimoto, 2017-04-06 20:29:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
jlklein@chromium.org, hansberry@chromium.org
Link to the patchset: https://codereview.chromium.org/2799683004/#ps80001
(title: "Added a missing #include.")

[commit-bot: I haz the power, 2017-04-06 20:30:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 21:54:41]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1491510596387790,
"parent_rev": "cab3dfe03ca689d5eb085e7a06418e22cbf31a42", "commit_rev":
"0371cd7b822641355ec9fa5977070e73af2210cc"}

[commit-bot: I haz the power, 2017-04-06 21:55:34]

Description was changed from

==========
[CrOS Tether] Add FakeCryptAuthService, a test double for CryptAuthService.

BUG=672263
==========

to

==========
[CrOS Tether] Add FakeCryptAuthService, a test double for CryptAuthService.

BUG=672263

Review-Url: https://codereview.chromium.org/2799683004
Cr-Commit-Position: refs/heads/master@{#462637}
Committed:
https://chromium.googlesource.com/chromium/src/+/0371cd7b822641355ec9fa597707...
==========

[commit-bot: I haz the power, 2017-04-06 21:55:35]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/0371cd7b822641355ec9fa597707...