Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2799653004: Open the settings tab in the message center when clicking the settings button on a notification. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Open the settings tab in the message center when clicking the settings button on a notification. Before this change, clicking the settings button on a notification opens the notification section in the settings window (chrome://settings) BUG=706658 Review-Url: https://codereview.chromium.org/2799653004 Cr-Commit-Position: refs/heads/master@{#462815} Committed: https://chromium.googlesource.com/chromium/src/+/f7d02d633ab7cb42632521709869212cdca3a835

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/message_center/views/message_center_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/views/message_popup_collection.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (12 generated)
yhanada
PTAL. Thanks!
3 years, 8 months ago (2017-04-06 08:15:57 UTC) #2
yoshiki
Thanks! Could you change the behavior of clicking popup notifications (toasts) as well?
3 years, 8 months ago (2017-04-07 06:32:44 UTC) #7
yhanada
On 2017/04/07 06:32:44, yoshiki wrote: > Thanks! Could you change the behavior of clicking popup ...
3 years, 8 months ago (2017-04-07 07:11:38 UTC) #8
yoshiki
Thanks! LGTM
3 years, 8 months ago (2017-04-07 07:26:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799653004/20001
3 years, 8 months ago (2017-04-07 09:09:00 UTC) #15
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 09:13:37 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f7d02d633ab7cb42632521709869...

Powered by Google App Engine
This is Rietveld 408576698