Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 2799613003: Un-skipped wpt embedded enforcement tests (Closed)

Created:
3 years, 8 months ago by andypaicu
Modified:
3 years, 8 months ago
Reviewers:
Mike West
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Un-skipped wpt embedded enforcement tests Un-skipped all tests except one that we are not passing Moved the one test into its own separate file to make it possible to skip Removed weaker and duplicated tests in our local test folder BUG=694525 Review-Url: https://codereview.chromium.org/2799613003 Cr-Commit-Position: refs/heads/master@{#462408} Committed: https://chromium.googlesource.com/chromium/src/+/435a8ebb9ce277198befecfb34d9493de1d6e9c7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -726 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/embedding_csp-header.html View 1 chunk +0 lines, -3 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/content-security-policy/embedded-enforcement/embedding_csp-header-invalid-format.html View 1 chunk +1 line, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/allow_csp_from-header.html View 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/embedding_csp-header.html View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/iframe-csp-attribute.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/subsumption_algorithm-general.html View 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/subsumption_algorithm-protocols-paths.html View 1 chunk +0 lines, -125 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/subsumption_algorithm-self.html View 1 chunk +0 lines, -108 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/embeddedEnforcement/subsumption_algorithm-wildcards-in-hosts-ports.html View 1 chunk +0 lines, -181 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
andypaicu
3 years, 8 months ago (2017-04-06 08:09:11 UTC) #4
Mike West
Yay! Thanks! LGTM.
3 years, 8 months ago (2017-04-06 08:55:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799613003/1
3 years, 8 months ago (2017-04-06 09:53:00 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 09:57:48 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/435a8ebb9ce277198befecfb34d9...

Powered by Google App Engine
This is Rietveld 408576698