cc: Fix VideoResourceUpdater color conversion

cc: Fix VideoResourceUpdater color conversion

This was assuming that YUV to RGB conversion had been done if the output
format was YUV, which is the opposite of what should be happening.

Make the CHECK for extra YUV to RGB conversion happen always, by adding
a "can ignore for testing" flag for the pixel tests that violate this
assumption.

BUG=709099
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2799603006
Cr-Commit-Position: refs/heads/master@{#462742}
Committed: https://chromium.googlesource.com/chromium/src/+/8d25b83269837337206aede5522dea9a90daa093

[ccameron, 2017-04-06 23:55:30]

Description was changed from

==========
cc: Fix VideoResourceUpdater color conversion

This was assuming that YUV to RGB conversion had been done if the output
format was YUV, which is the opposite of what should be happening.

Make the CHECK for extra YUV to RGB conversion happen always, by adding
a "can ignore for testing" flag for the pixel tests that violate this
assumption.

BUG=709099
==========

to

==========
cc: Fix VideoResourceUpdater color conversion

This was assuming that YUV to RGB conversion had been done if the output
format was YUV, which is the opposite of what should be happening.

Make the CHECK for extra YUV to RGB conversion happen always, by adding
a "can ignore for testing" flag for the pixel tests that violate this
assumption.

BUG=709099
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-04-06 23:57:46]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-06 23:58:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-04-07 00:04:00]

ccameron@chromium.org changed reviewers:
+ hubbe@chromium.org

[ccameron, 2017-04-07 00:04:01]

I'm very surprised that this slipped through testing (it blows up Canary pretty
bad)

https://codereview.chromium.org/2799603006/diff/1/cc/resources/video_resource...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2799603006/diff/1/cc/resources/video_resource...
cc/resources/video_resource_updater.cc:638: }
This is the root of the bug.

I don't see how this didn't blow up all of the time during tests.

[hubbe, 2017-04-07 00:19:31]

lgtm

https://codereview.chromium.org/2799603006/diff/1/cc/resources/video_resource...
File cc/resources/video_resource_updater.cc (right):

https://codereview.chromium.org/2799603006/diff/1/cc/resources/video_resource...
cc/resources/video_resource_updater.cc:638: }
On 2017/04/07 00:04:01, ccameron wrote:
> This is the root of the bug.
> 
> I don't see how this didn't blow up all of the time during tests.

Acknowledged.

[commit-bot: I haz the power, 2017-04-07 01:03:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 01:03:37]

Dry run: This issue passed the CQ dry run.

[ccameron, 2017-04-07 02:00:53]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-04-07 02:01:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 02:06:54]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491530453028870, "parent_rev":
"2daf853b6542cd08c23618991790870c07fb91f4", "commit_rev":
"8d25b83269837337206aede5522dea9a90daa093"}

[commit-bot: I haz the power, 2017-04-07 02:07:41]

Description was changed from

==========
cc: Fix VideoResourceUpdater color conversion

This was assuming that YUV to RGB conversion had been done if the output
format was YUV, which is the opposite of what should be happening.

Make the CHECK for extra YUV to RGB conversion happen always, by adding
a "can ignore for testing" flag for the pixel tests that violate this
assumption.

BUG=709099
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Fix VideoResourceUpdater color conversion

This was assuming that YUV to RGB conversion had been done if the output
format was YUV, which is the opposite of what should be happening.

Make the CHECK for extra YUV to RGB conversion happen always, by adding
a "can ignore for testing" flag for the pixel tests that violate this
assumption.

BUG=709099
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2799603006
Cr-Commit-Position: refs/heads/master@{#462742}
Committed:
https://chromium.googlesource.com/chromium/src/+/8d25b83269837337206aede5522d...
==========

[commit-bot: I haz the power, 2017-04-07 02:07:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8d25b83269837337206aede5522d...