Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2799593003: [MD Bookmarks] Allow dragging onto empty bookmark lists. (Closed)

Created:
3 years, 8 months ago by calamity
Modified:
3 years, 8 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dcheng, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Allow dragging onto empty bookmark lists. BUG=692843 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2799593003 Cr-Commit-Position: refs/heads/master@{#463550} Committed: https://chromium.googlesource.com/chromium/src/+/2538f82823749761782a157ff3503834ee3262cc

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -6 lines) Patch
M chrome/browser/resources/md_bookmarks/dnd_manager.js View 1 6 chunks +34 lines, -5 lines 0 comments Download
M chrome/browser/resources/md_bookmarks/list.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/md_bookmarks/list.js View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/webui/md_bookmarks/dnd_manager_test.js View 1 2 chunks +37 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
calamity
3 years, 8 months ago (2017-04-06 07:02:59 UTC) #4
tsergeant
lgtm The super basic blue highlight looks fine for now -- Alan might have something ...
3 years, 8 months ago (2017-04-07 03:30:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799593003/40001
3 years, 8 months ago (2017-04-11 05:14:31 UTC) #12
commit-bot: I haz the power
3 years, 8 months ago (2017-04-11 06:23:57 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2538f82823749761782a157ff350...

Powered by Google App Engine
This is Rietveld 408576698