Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2799573003: Migrate WTF::HashCountedSet::remove() to ::erase() (Closed)

Created:
3 years, 8 months ago by pilgrim_google
Modified:
3 years, 8 months ago
Reviewers:
haraken, Yuta Kitamura
CC:
Mads Ager (chromium), darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, Eric Willigers, fmalita+watch_chromium.org, fs, gavinp+loader_chromium.org, gyuyoung2, Nate Chapin, kinuko+watch, kouhei+heap_chromium.org, kouhei+svg_chromium.org, loading-reviews_chromium.org, loading-reviews+fetch_chromium.org, oilpan-reviews, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof, tyoshino+watch_chromium.org, jsbell
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::HashCountedSet::remove() to ::erase() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2799573003 Cr-Commit-Position: refs/heads/master@{#462091} Committed: https://chromium.googlesource.com/chromium/src/+/a097aa0c267a3ac5dc99af963461148fb64bb6a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageGeneratorValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/EventHandlerRegistry.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLFrameOwnerElement.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/resource/ImageResourceContent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElementProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/Database.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/HeapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/Resource.cpp View 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/HashCountedSet.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
pilgrim_google
3 years, 8 months ago (2017-04-05 14:25:26 UTC) #2
haraken
LGTM
3 years, 8 months ago (2017-04-05 14:31:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799573003/1
3 years, 8 months ago (2017-04-05 14:34:45 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 16:05:04 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a097aa0c267a3ac5dc99af963461...

Powered by Google App Engine
This is Rietveld 408576698