Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2799573002: Fix the check to distinguish accessibility events. (Closed)

Created:
3 years, 8 months ago by yhanada
Modified:
3 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the check to distinguish accessibility events. BUG=703989 TEST=Check that a mouse click on the expand button expands the notification and Ctrl+Space with ChromeVox on the notification expands/collapse the notification. Review-Url: https://codereview.chromium.org/2799573002 Cr-Commit-Position: refs/heads/master@{#462016} Committed: https://chromium.googlesource.com/chromium/src/+/06ee0285ea203e11aca7161d8ea029f643f085ba

Patch Set 1 #

Total comments: 1

Patch Set 2 : add a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
yhanada
PTAL.
3 years, 8 months ago (2017-04-05 08:46:41 UTC) #2
yoshiki
https://codereview.chromium.org/2799573002/diff/1/ui/arc/notification/arc_custom_notification_view.cc File ui/arc/notification/arc_custom_notification_view.cc (right): https://codereview.chromium.org/2799573002/diff/1/ui/arc/notification/arc_custom_notification_view.cc#newcode558 ui/arc/notification/arc_custom_notification_view.cc:558: event.target() == nullptr) { Could you update the comment ...
3 years, 8 months ago (2017-04-05 08:55:51 UTC) #4
yoshiki
lgtm
3 years, 8 months ago (2017-04-05 08:56:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799573002/20001
3 years, 8 months ago (2017-04-05 09:03:05 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 09:34:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/06ee0285ea203e11aca7161d8ea0...

Powered by Google App Engine
This is Rietveld 408576698