Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2314)

Unified Diff: chrome/browser/resources/settings/site_settings/site_data_details_subpage.js

Issue 2799563003: MD Settings: Move browserProxies outside of Polymer "properties". (Closed)
Patch Set: Address comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
diff --git a/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js b/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
index 7196b784d4898740f2124c47f748fafb1c79ef69..ed83ad966cd95f2fdbef0f3a6e170d1fc659efbd 100644
--- a/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
+++ b/chrome/browser/resources/settings/site_settings/site_data_details_subpage.js
@@ -15,12 +15,6 @@ Polymer({
properties: {
/**
- * The browser proxy used to retrieve and change cookies.
- * @type {settings.SiteSettingsPrefsBrowserProxy}
- */
- browserProxy: Object,
-
- /**
* The cookie entries for the given site.
* @type {!Array<!CookieDetails>}
* @private
@@ -40,9 +34,15 @@ Polymer({
siteId_: String,
},
+ /**
+ * The browser proxy used to retrieve and change cookies.
+ * @private {?settings.SiteSettingsPrefsBrowserProxy}
+ */
+ browserProxy_: null,
+
/** @override */
ready: function() {
- this.browserProxy =
+ this.browserProxy_ =
settings.SiteSettingsPrefsBrowserProxyImpl.getInstance();
this.addWebUIListener('onTreeItemRemoved',
@@ -69,7 +69,7 @@ Polymer({
getCookieDetails_: function() {
if (!this.site_)
return;
- this.browserProxy.getCookieDetails(this.site_).then(
+ this.browserProxy_.getCookieDetails(this.site_).then(
this.onCookiesLoaded_.bind(this),
this.onCookiesLoadFailed_.bind(this));
},
@@ -124,7 +124,7 @@ Polymer({
* @private
*/
onRemove_: function(event) {
- this.browserProxy.removeCookie(
+ this.browserProxy_.removeCookie(
/** @type {!CookieDetails} */(event.currentTarget.dataset).idPath);
},
@@ -132,7 +132,7 @@ Polymer({
* A handler for when the user opts to remove all cookies.
*/
removeAll: function() {
- this.browserProxy.removeCookie(this.siteId_);
+ this.browserProxy_.removeCookie(this.siteId_);
},
});
« no previous file with comments | « chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698