Provide a std::vector compliant empty() method for WebVector.

Provide a std::vector compliant empty() method for WebVector.

Provide a std::vector compliant empty() method for WebVector, start moving code
over to use it. This is preperation to completely replace WebVector with
std::vector, as this abstraction is no longer useful

BUG=708389
Review-Url: https://codereview.chromium.org/2799553002
Cr-Commit-Position: refs/heads/master@{#462011}
Committed: https://chromium.googlesource.com/chromium/src/+/459f82aea36f5e53298407cb3831ec0f2d22c3ef

[slangley, 2017-04-05 04:30:00]

Description was changed from

==========
Provide a std::vector compliant empty() method for WebVector.

Provide a std::vector compliant empty() method for WebVector, start moving code
over to use it. This is preperation to completely replace WebVector with
std::vector, as this abstraction is no longer useful.s

BUG=708389
==========

to

==========
Provide a std::vector compliant empty() method for WebVector.

Provide a std::vector compliant empty() method for WebVector, start moving code
over to use it. This is preperation to completely replace WebVector with
std::vector, as this abstraction is no longer useful

BUG=708389
==========

[slangley, 2017-04-05 04:30:32]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-04-05 04:48:54]

This CL LGTM but...

> This is preperation to completely replace WebVector with
> std::vector, as this abstraction is no longer useful

how much work will it be needed?

[slangley, 2017-04-05 04:58:27]

On 2017/04/05 at 04:48:54, haraken wrote:
> This CL LGTM but...
> 
> > This is preperation to completely replace WebVector with
> > std::vector, as this abstraction is no longer useful
> 
> how much work will it be needed?

$ find . -type f | egrep "h$" | xargs fgrep -l "WebVector" | wc -l
204

I'm presuming we can just shuffle a few files over at a time at a slow pace. I
am hoping that if the WebVector && std::vector API matches then subsequent
changes are simple and fast.

[haraken, 2017-04-05 05:01:07]

On 2017/04/05 04:58:27, slangley wrote:
> On 2017/04/05 at 04:48:54, haraken wrote:
> > This CL LGTM but...
> > 
> > > This is preperation to completely replace WebVector with
> > > std::vector, as this abstraction is no longer useful
> > 
> > how much work will it be needed?
> 
> $ find . -type f | egrep "h$" | xargs fgrep -l "WebVector" | wc -l
> 204
> 
> I'm presuming we can just shuffle a few files over at a time at a slow pace. I
> am hoping that if the WebVector && std::vector API matches then subsequent
> changes are simple and fast.

If it's not a lot of work, sounds good. I just wanted to make sure that removing
web/ would be more important :)

[slangley, 2017-04-05 05:08:48]

On 2017/04/05 at 05:01:07, haraken wrote:
> On 2017/04/05 04:58:27, slangley wrote:
> > On 2017/04/05 at 04:48:54, haraken wrote:
> > > This CL LGTM but...
> > > 
> > > > This is preperation to completely replace WebVector with
> > > > std::vector, as this abstraction is no longer useful
> > > 
> > > how much work will it be needed?
> > 
> > $ find . -type f | egrep "h$" | xargs fgrep -l "WebVector" | wc -l
> > 204
> > 
> > I'm presuming we can just shuffle a few files over at a time at a slow pace.
I
> > am hoping that if the WebVector && std::vector API matches then subsequent
> > changes are simple and fast.
> 
> If it's not a lot of work, sounds good. I just wanted to make sure that
removing web/ would be more important :)

I think the two are complimentary ;)

[slangley, 2017-04-05 05:09:04]

The CQ bit was checked by slangley@chromium.org

[commit-bot: I haz the power, 2017-04-05 05:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 08:48:10]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1491368944383650, "parent_rev":
"80cc48147b27aa364144e4b6d49524fb111274a9", "commit_rev":
"459f82aea36f5e53298407cb3831ec0f2d22c3ef"}

[commit-bot: I haz the power, 2017-04-05 08:49:24]

Description was changed from

==========
Provide a std::vector compliant empty() method for WebVector.

Provide a std::vector compliant empty() method for WebVector, start moving code
over to use it. This is preperation to completely replace WebVector with
std::vector, as this abstraction is no longer useful

BUG=708389
==========

to

==========
Provide a std::vector compliant empty() method for WebVector.

Provide a std::vector compliant empty() method for WebVector, start moving code
over to use it. This is preperation to completely replace WebVector with
std::vector, as this abstraction is no longer useful

BUG=708389

Review-Url: https://codereview.chromium.org/2799553002
Cr-Commit-Position: refs/heads/master@{#462011}
Committed:
https://chromium.googlesource.com/chromium/src/+/459f82aea36f5e53298407cb3831...
==========

[commit-bot: I haz the power, 2017-04-05 08:49:25]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/459f82aea36f5e53298407cb3831...