Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 2799513002: Update how longpress is done in testOpenLinkInNewTab. (Closed)

Created:
3 years, 8 months ago by baxley
Modified:
3 years, 8 months ago
Reviewers:
Olivier
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, asvitkine+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Update how longpress is done in testOpenLinkInNewTab. Explicitly perform a longpress on the element ID of the link, rather than long pressing the webview. BUG= Review-Url: https://codereview.chromium.org/2799513002 Cr-Commit-Position: refs/heads/master@{#462004} Committed: https://chromium.googlesource.com/chromium/src/+/1b260df384fd2c06a4353ca3cd9114cf77a46033

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M ios/chrome/browser/metrics/tab_usage_recorder_egtest.mm View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
baxley
3 years, 8 months ago (2017-04-04 21:30:55 UTC) #2
Olivier
lgtm
3 years, 8 months ago (2017-04-05 07:22:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799513002/1
3 years, 8 months ago (2017-04-05 07:23:07 UTC) #5
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 07:36:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b260df384fd2c06a4353ca3cd91...

Powered by Google App Engine
This is Rietveld 408576698