Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2799453003:
Remove -no-audio option for headless Android emulators. (Closed)
DescriptionRemove -no-audio option for headless Android emulators.
When passing --headless to avd.py, it fails to start an emulator
and this message is printed:
qemu-system-i386: -audio: invalid option
Taking out the -no-audio option allows the emulator to launch
successfully.
BUG=NONE
Review-Url: https://codereview.chromium.org/2799453003
Cr-Commit-Position: refs/heads/master@{#462106}
Committed: https://chromium.googlesource.com/chromium/src/+/e5a1eaf77cc75b28dc7c40a14fdc412fe9a58242
Patch Set 1 #
Messages
Total messages: 17 (6 generated)
sanfin@chromium.org changed reviewers: + jbudorick@chromium.org
Hey, I'm trying to get headless Android emulators to work for development of Chromecast for Android TV, and ran into an issue starting emulators in headless mode. When I remove the -no-audio option from the start command, the emulators correctly launch. I'm not sure if we should keep this option; if there's a better fix, we can abandon this change. PTAL.
On 2017/04/04 21:59:31, Simeon wrote: > Hey, I'm trying to get headless Android emulators to work for development of > Chromecast for Android TV, and ran into an issue starting emulators in headless > mode. When I remove the -no-audio option from the start command, the emulators > correctly launch. I'm not sure if we should keep this option; if there's a > better fix, we can abandon this change. > > PTAL. it says '-audio' is the invalid option? hmm, that ... seems like a bug somewhere in the emulator tool. Does -noaudio work?
On 2017/04/04 22:06:47, jbudorick wrote: > On 2017/04/04 21:59:31, Simeon wrote: > > Hey, I'm trying to get headless Android emulators to work for development of > > Chromecast for Android TV, and ran into an issue starting emulators in > headless > > mode. When I remove the -no-audio option from the start command, the emulators > > correctly launch. I'm not sure if we should keep this option; if there's a > > better fix, we can abandon this change. > > > > PTAL. > > it says '-audio' is the invalid option? hmm, that ... seems like a bug somewhere > in the emulator tool. > > Does -noaudio work? I tried that, and it didn't.
On 2017/04/04 22:12:30, Simeon wrote: > On 2017/04/04 22:06:47, jbudorick wrote: > > On 2017/04/04 21:59:31, Simeon wrote: > > > Hey, I'm trying to get headless Android emulators to work for development of > > > Chromecast for Android TV, and ran into an issue starting emulators in > > headless > > > mode. When I remove the -no-audio option from the start command, the > emulators > > > correctly launch. I'm not sure if we should keep this option; if there's a > > > better fix, we can abandon this change. > > > > > > PTAL. > > > > it says '-audio' is the invalid option? hmm, that ... seems like a bug > somewhere > > in the emulator tool. > > > > Does -noaudio work? > > I tried that, and it didn't. Same failure mode, or something else?
On 2017/04/04 22:14:13, jbudorick wrote: > On 2017/04/04 22:12:30, Simeon wrote: > > On 2017/04/04 22:06:47, jbudorick wrote: > > > On 2017/04/04 21:59:31, Simeon wrote: > > > > Hey, I'm trying to get headless Android emulators to work for development > of > > > > Chromecast for Android TV, and ran into an issue starting emulators in > > > headless > > > > mode. When I remove the -no-audio option from the start command, the > > emulators > > > > correctly launch. I'm not sure if we should keep this option; if there's a > > > > better fix, we can abandon this change. > > > > > > > > PTAL. > > > > > > it says '-audio' is the invalid option? hmm, that ... seems like a bug > > somewhere > > > in the emulator tool. > > > > > > Does -noaudio work? > > > > I tried that, and it didn't. > > Same failure mode, or something else? Same: qemu-system-i386: -audio: invalid option
On 2017/04/04 22:16:50, Simeon wrote: > On 2017/04/04 22:14:13, jbudorick wrote: > > On 2017/04/04 22:12:30, Simeon wrote: > > > On 2017/04/04 22:06:47, jbudorick wrote: > > > > On 2017/04/04 21:59:31, Simeon wrote: > > > > > Hey, I'm trying to get headless Android emulators to work for > development > > of > > > > > Chromecast for Android TV, and ran into an issue starting emulators in > > > > headless > > > > > mode. When I remove the -no-audio option from the start command, the > > > emulators > > > > > correctly launch. I'm not sure if we should keep this option; if there's > a > > > > > better fix, we can abandon this change. > > > > > > > > > > PTAL. > > > > > > > > it says '-audio' is the invalid option? hmm, that ... seems like a bug > > > somewhere > > > > in the emulator tool. > > > > > > > > Does -noaudio work? > > > > > > I tried that, and it didn't. > > > > Same failure mode, or something else? > > Same: > > qemu-system-i386: -audio: invalid option Odd. I'm going to investigate this a bit more, but lgtm all the same.
The CQ bit was checked by sanfin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/04 22:19:20, jbudorick wrote: > On 2017/04/04 22:16:50, Simeon wrote: > > On 2017/04/04 22:14:13, jbudorick wrote: > > > On 2017/04/04 22:12:30, Simeon wrote: > > > > On 2017/04/04 22:06:47, jbudorick wrote: > > > > > On 2017/04/04 21:59:31, Simeon wrote: > > > > > > Hey, I'm trying to get headless Android emulators to work for > > development > > > of > > > > > > Chromecast for Android TV, and ran into an issue starting emulators in > > > > > headless > > > > > > mode. When I remove the -no-audio option from the start command, the > > > > emulators > > > > > > correctly launch. I'm not sure if we should keep this option; if > there's > > a > > > > > > better fix, we can abandon this change. > > > > > > > > > > > > PTAL. > > > > > > > > > > it says '-audio' is the invalid option? hmm, that ... seems like a bug > > > > somewhere > > > > > in the emulator tool. > > > > > > > > > > Does -noaudio work? > > > > > > > > I tried that, and it didn't. > > > > > > Same failure mode, or something else? > > > > Same: > > > > qemu-system-i386: -audio: invalid option > > Odd. I'm going to investigate this a bit more, but lgtm all the same. Thanks! I wouldn't be surprised if there is some bug in the emulator tool, but hopefully this won't break anything :)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by sanfin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1491406950243190, "parent_rev":
"3f4ab462d9bdaae2d2049d798694083b959a8703", "commit_rev":
"e5a1eaf77cc75b28dc7c40a14fdc412fe9a58242"}
Message was sent while issue was closed.
Description was changed from ========== Remove -no-audio option for headless Android emulators. When passing --headless to avd.py, it fails to start an emulator and this message is printed: qemu-system-i386: -audio: invalid option Taking out the -no-audio option allows the emulator to launch successfully. BUG=NONE ========== to ========== Remove -no-audio option for headless Android emulators. When passing --headless to avd.py, it fails to start an emulator and this message is printed: qemu-system-i386: -audio: invalid option Taking out the -no-audio option allows the emulator to launch successfully. BUG=NONE Review-Url: https://codereview.chromium.org/2799453003 Cr-Commit-Position: refs/heads/master@{#462106} Committed: https://chromium.googlesource.com/chromium/src/+/e5a1eaf77cc75b28dc7c40a14fdc... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e5a1eaf77cc75b28dc7c40a14fdc... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
