Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2799393003: Add a browser-side kill switch to getInstalledRelatedApps. (Closed)

Created:
3 years, 8 months ago by Matt Giuca
Modified:
3 years, 8 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a browser-side kill switch to getInstalledRelatedApps. If the Origin Trial is disabled from a server config, the Mojo service will no longer be created. This prevents a compromised renderer from using the service, even after the API is shut down in the event of a security problem being discovered. BUG=703476 Review-Url: https://codereview.chromium.org/2799393003 Cr-Commit-Position: refs/heads/master@{#462768} Committed: https://chromium.googlesource.com/chromium/src/+/3d9a196e23ef92fd8a270e31da6b2bf06d9609b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Matt Giuca
sammc: For review, since I cargo-culted your killswitch for WebShare :)
3 years, 8 months ago (2017-04-07 04:13:36 UTC) #2
Sam McNally
lgtm
3 years, 8 months ago (2017-04-07 04:36:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799393003/1
3 years, 8 months ago (2017-04-07 04:40:19 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 05:27:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3d9a196e23ef92fd8a270e31da6b...

Powered by Google App Engine
This is Rietveld 408576698