Make NTP Promo invalid if text parameter is not in lookup table.

Make NTP Promo invalid if text parameter is not in lookup table.

Previously, if the promo text parameter was not found in the
localization lookup table, the promo would be considered valid and the
text would be displayed as is. With this CL, it is now required that
the text parameter exist in the lookup table in order for the promo
to be valid. The CL also does general NTP Promo cleanup and adds
unit tests.

BUG=703440
Review-Url: https://codereview.chromium.org/2799383002
Cr-Commit-Position: refs/heads/master@{#462918}
Committed: https://chromium.googlesource.com/chromium/src/+/d50c8a52e838178b0ceedca4e35ed67c3ffa8e57

[gchatz, 2017-04-07 01:51:24]

gchatz@chromium.org changed reviewers:
+ justincohen@chromium.org

[gchatz, 2017-04-07 01:52:04]

Description was changed from

==========
Make NTP Promo invalid if text parameter is not in lookup table.

Previously, if the promo text parameter was not found in the
localization lookup table, the promo would be considered valid and the
text would be displayed as is. With this CL, it is now required that
the pass parameter exist in the lookup table in order for the promo
to be valid. The CL also does general NTP Promo cleanup, and adds
unit tests.

BUG=703440
==========

to

==========
Make NTP Promo invalid if text parameter is not in lookup table.

Previously, if the promo text parameter was not found in the
localization lookup table, the promo would be considered valid and the
text would be displayed as is. With this CL, it is now required that
the text parameter exist in the lookup table in order for the promo
to be valid. The CL also does general NTP Promo cleanup and adds
unit tests.

BUG=703440
==========

[justincohen, 2017-04-07 16:20:58]

lgtm

[gchatz, 2017-04-07 17:34:38]

The CQ bit was checked by gchatz@chromium.org

[commit-bot: I haz the power, 2017-04-07 17:35:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 17:52:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491586478472700,
"parent_rev": "380bc71f286663403e7706aedcf66f724c89b584", "commit_rev":
"d50c8a52e838178b0ceedca4e35ed67c3ffa8e57"}

[commit-bot: I haz the power, 2017-04-07 17:53:09]

Description was changed from

==========
Make NTP Promo invalid if text parameter is not in lookup table.

Previously, if the promo text parameter was not found in the
localization lookup table, the promo would be considered valid and the
text would be displayed as is. With this CL, it is now required that
the text parameter exist in the lookup table in order for the promo
to be valid. The CL also does general NTP Promo cleanup and adds
unit tests.

BUG=703440
==========

to

==========
Make NTP Promo invalid if text parameter is not in lookup table.

Previously, if the promo text parameter was not found in the
localization lookup table, the promo would be considered valid and the
text would be displayed as is. With this CL, it is now required that
the text parameter exist in the lookup table in order for the promo
to be valid. The CL also does general NTP Promo cleanup and adds
unit tests.

BUG=703440

Review-Url: https://codereview.chromium.org/2799383002
Cr-Commit-Position: refs/heads/master@{#462918}
Committed:
https://chromium.googlesource.com/chromium/src/+/d50c8a52e838178b0ceedca4e35e...
==========

[commit-bot: I haz the power, 2017-04-07 17:53:10]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d50c8a52e838178b0ceedca4e35e...