Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: runtime/vm/flow_graph_compiler_dbc.cc

Issue 2799373002: Pass a second type argument vector to all type instantiation calls in the VM. (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler_dbc.cc
diff --git a/runtime/vm/flow_graph_compiler_dbc.cc b/runtime/vm/flow_graph_compiler_dbc.cc
index 5e0f8bce871702bc31336f5531f12c7461e89934..47cfb97c4d0c605ba11660405c98e1837f27ef24 100644
--- a/runtime/vm/flow_graph_compiler_dbc.cc
+++ b/runtime/vm/flow_graph_compiler_dbc.cc
@@ -234,8 +234,9 @@ void FlowGraphCompiler::GenerateAssertAssignable(TokenPosition token_pos,
}
if (is_optimizing()) {
- __ Push(locs->in(0).reg());
- __ Push(locs->in(1).reg());
+ __ Push(locs->in(0).reg()); // Instance.
+ __ Push(locs->in(1).reg()); // Instantiator type arguments.
+ __ Push(locs->in(2).reg()); // Function type arguments.
}
__ PushConstant(dst_type);
__ PushConstant(dst_name);
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698