Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Side by Side Diff: runtime/vm/flow_graph_compiler_dbc.cc

Issue 2799373002: Pass a second type argument vector to all type instantiation calls in the VM. (Closed)
Patch Set: addressed comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_DBC. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_DBC.
6 #if defined(TARGET_ARCH_DBC) 6 #if defined(TARGET_ARCH_DBC)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
(...skipping 216 matching lines...) Expand 10 before | Expand all | Expand 10 after
227 LocationSummary* locs) { 227 LocationSummary* locs) {
228 SubtypeTestCache& test_cache = SubtypeTestCache::Handle(); 228 SubtypeTestCache& test_cache = SubtypeTestCache::Handle();
229 if (!dst_type.IsVoidType() && dst_type.IsInstantiated()) { 229 if (!dst_type.IsVoidType() && dst_type.IsInstantiated()) {
230 test_cache = SubtypeTestCache::New(); 230 test_cache = SubtypeTestCache::New();
231 } else if (!dst_type.IsInstantiated() && 231 } else if (!dst_type.IsInstantiated() &&
232 (dst_type.IsTypeParameter() || dst_type.IsType())) { 232 (dst_type.IsTypeParameter() || dst_type.IsType())) {
233 test_cache = SubtypeTestCache::New(); 233 test_cache = SubtypeTestCache::New();
234 } 234 }
235 235
236 if (is_optimizing()) { 236 if (is_optimizing()) {
237 __ Push(locs->in(0).reg()); 237 __ Push(locs->in(0).reg()); // Instance.
238 __ Push(locs->in(1).reg()); 238 __ Push(locs->in(1).reg()); // Instantiator type arguments.
239 __ Push(locs->in(2).reg()); // Function type arguments.
239 } 240 }
240 __ PushConstant(dst_type); 241 __ PushConstant(dst_type);
241 __ PushConstant(dst_name); 242 __ PushConstant(dst_name);
242 243
243 if (dst_type.IsMalformedOrMalbounded()) { 244 if (dst_type.IsMalformedOrMalbounded()) {
244 __ BadTypeError(); 245 __ BadTypeError();
245 } else { 246 } else {
246 bool may_be_smi = false; 247 bool may_be_smi = false;
247 if (!dst_type.IsVoidType() && dst_type.IsInstantiated()) { 248 if (!dst_type.IsVoidType() && dst_type.IsInstantiated()) {
248 const Class& type_class = Class::Handle(zone(), dst_type.type_class()); 249 const Class& type_class = Class::Handle(zone(), dst_type.type_class());
(...skipping 325 matching lines...) Expand 10 before | Expand all | Expand 10 after
574 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) { 575 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
575 UNIMPLEMENTED(); 576 UNIMPLEMENTED();
576 } 577 }
577 578
578 579
579 #undef __ 580 #undef __
580 581
581 } // namespace dart 582 } // namespace dart
582 583
583 #endif // defined TARGET_ARCH_DBC 584 #endif // defined TARGET_ARCH_DBC
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698