Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: third_party/WebKit/LayoutTests/fast/multicol/span/outside-multicol.html

Issue 2799363003: A column-span:all element should always establish a new formatting context. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/fast/multicol/span/outside-multicol.html
diff --git a/third_party/WebKit/LayoutTests/fast/multicol/span/outside-multicol.html b/third_party/WebKit/LayoutTests/fast/multicol/span/outside-multicol.html
new file mode 100644
index 0000000000000000000000000000000000000000..589c70cf45e25d2aaa96281ccce0c43aef220ee9
--- /dev/null
+++ b/third_party/WebKit/LayoutTests/fast/multicol/span/outside-multicol.html
@@ -0,0 +1,21 @@
+<!DOCTYPE html>
+<p>There should be a green square below.</p>
+<div style="position:relative;">
+ <div style="float:left; width:50px; height:100px; background:green;"></div>
+ <div id="invalidSpanner" style="column-span:all; width:50px; background:green;">
+ <div style="float:left; width:50px; height:100px;"></div>
+ </div>
+</div>
+<script src="../../../resources/testharness.js"></script>
+<script src="../../../resources/testharnessreport.js"></script>
+<script>
+ test(function() {
+ var invalidSpanner = document.getElementById("invalidSpanner");
+ // It should not overlap with floats in the same block formatting
+ // context.
+ assert_equals(invalidSpanner.offsetLeft, 50);
+ // It should establish a new block formatting context, so that it
+ // stretches to contain all floats inside.
+ assert_equals(invalidSpanner.offsetHeight, 100);
+ }, "Column spanner without ancestor multicol");
+</script>
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698