Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5983)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac.mm

Issue 2799343003: Add support for native extension notifications (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_platform_bridge_mac.mm
diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm
index 3e81cd6ea85eaf08ba44d3acab707bbdf50bccf8..3250c39725470a2e5860ee7da90aaad9a6c024ea 100644
--- a/chrome/browser/notifications/notification_platform_bridge_mac.mm
+++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm
@@ -179,8 +179,12 @@ void NotificationPlatformBridgeMac::Display(
[builder setTitle:base::SysUTF16ToNSString(notification.title())];
[builder setContextMessage:base::SysUTF16ToNSString(notification.message())];
+ bool requires_attribution =
+ notification.context_message().empty() &&
+ notification_type != NotificationCommon::EXTENSION;
Peter Beverloo 2017/04/07 02:26:53 Just checking for "notification_type != EXTENSION"
Miguel Garcia 2017/04/07 13:32:06 mm no? We need the class prefix :)
+
base::string16 subtitle =
- notification.context_message().empty()
+ requires_attribution
? url_formatter::FormatOriginForSecurityDisplay(
url::Origin(notification.origin_url()),
url_formatter::SchemeDisplay::OMIT_HTTP_AND_HTTPS)

Powered by Google App Engine
This is Rietveld 408576698