Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 2799323003: Fix PartitionAlloc cookies for large in-place reallocs (Closed)

Created:
3 years, 8 months ago by Tom Sepez
Modified:
3 years, 8 months ago
Reviewers:
palmer, haraken
CC:
Mads Ager (chromium), chromium-reviews, danakj+watch_chromium.org, Dai Mikurube (NOT FULLTIME), kouhei+heap_chromium.org, oilpan-reviews, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PartitionAlloc cookies for large in-place reallocs BUG=709271 Review-Url: https://codereview.chromium.org/2799323003 Cr-Commit-Position: refs/heads/master@{#463047} Committed: https://chromium.googlesource.com/chromium/src/+/8b56c3d42b97dd0d165daa6c1b3619f40ff2d6a4

Patch Set 1 : Test case that fails without patch #

Patch Set 2 : Fix issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M base/allocator/partition_allocator/partition_alloc.cc View 1 1 chunk +7 lines, -2 lines 0 comments Download
M base/allocator/partition_allocator/partition_alloc_unittest.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Tom Sepez
haraken, for review. palmer, fyi.
3 years, 8 months ago (2017-04-07 17:23:11 UTC) #5
palmer
lgtm
3 years, 8 months ago (2017-04-07 17:49:24 UTC) #6
haraken
LGTM
3 years, 8 months ago (2017-04-07 22:27:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799323003/20001
3 years, 8 months ago (2017-04-07 23:15:54 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 23:28:22 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8b56c3d42b97dd0d165daa6c1b36...

Powered by Google App Engine
This is Rietveld 408576698