Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 27993005: Revert 229521 "Revert 229507 "aura: Allow creating content_shell..." (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 229521 "Revert 229507 "aura: Allow creating content_shell..." Revert didn't help, so reland the change. > Revert 229507 "aura: Allow creating content_shell without views." > > Speculative. All windows bots on the main waterfall except for the clobber > builder started timing out during compile during a window that had only this > change and two test-only changes in the range. > > > aura: Allow creating content_shell without views. > > > > This builds content_shell with use_aura=1 and toolkit_views=0. > > > > BUG=none > > R=derat@chromium.org, jamescook@chromium.org, jochen@chromium.org > > > > Review URL: https://codereview.chromium.org/26695007 > > TBR=sadrul@chromium.org > > Review URL: https://codereview.chromium.org/30413002 TBR=thakis@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -311 lines) Patch
M trunk/src/build/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/content_shell.gypi View 2 chunks +18 lines, -4 lines 0 comments Download
M trunk/src/content/shell/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/shell/browser/shell.h View 2 chunks +8 lines, -0 lines 0 comments Download
M trunk/src/content/shell/browser/shell.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A + trunk/src/content/shell/browser/shell_aura.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/content/shell/browser/shell_aura.cc View 2 chunks +107 lines, -303 lines 0 comments Download
A + trunk/src/content/shell/browser/shell_views.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ui/events/events.gyp View 1 chunk +1 line, -3 lines 0 comments Download
M trunk/src/ui/ui.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
7 years, 2 months ago (2013-10-19 06:47:38 UTC) #1
Nico
7 years, 2 months ago (2013-10-19 06:47:48 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r229524.

Powered by Google App Engine
This is Rietveld 408576698