Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 30413002: Revert 229507 "aura: Allow creating content_shell without views." (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
Reviewers:
sadrul
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 229507 "aura: Allow creating content_shell without views." Speculative. All windows bots on the main waterfall except for the clobber builder started timing out during compile during a window that had only this change and two test-only changes in the range. > aura: Allow creating content_shell without views. > > This builds content_shell with use_aura=1 and toolkit_views=0. > > BUG=none > R=derat@chromium.org, jamescook@chromium.org, jochen@chromium.org > > Review URL: https://codereview.chromium.org/26695007 TBR=sadrul@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229521

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -575 lines) Patch
M trunk/src/build/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/content_shell.gypi View 2 chunks +4 lines, -18 lines 0 comments Download
M trunk/src/content/shell/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M trunk/src/content/shell/browser/shell.h View 2 chunks +0 lines, -8 lines 0 comments Download
M trunk/src/content/shell/browser/shell.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D trunk/src/content/shell/browser/shell_aura.h View 1 chunk +0 lines, -46 lines 0 comments Download
M trunk/src/content/shell/browser/shell_aura.cc View 2 chunks +303 lines, -107 lines 0 comments Download
D trunk/src/content/shell/browser/shell_views.cc View 1 chunk +0 lines, -388 lines 0 comments Download
M trunk/src/ui/events/events.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M trunk/src/ui/ui.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
7 years, 2 months ago (2013-10-19 05:27:43 UTC) #1
Nico
Committed patchset #1 manually as r229521.
7 years, 2 months ago (2013-10-19 05:27:57 UTC) #2
Nico
This didn't help, I've reverted the revert. On Fri, Oct 18, 2013 at 10:27 PM, ...
7 years, 2 months ago (2013-10-19 06:46:40 UTC) #3
pfeldman
7 years, 2 months ago (2013-10-19 06:55:38 UTC) #4
Message was sent while issue was closed.
ToT does not like it either:
http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/b...

Powered by Google App Engine
This is Rietveld 408576698