Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2799283003: remove legacy code from PlatformCanvas days (Closed)

Created:
3 years, 8 months ago by reed1
Modified:
3 years, 8 months ago
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

remove legacy code from PlatformCanvas days According to the comment, this extra copy was needed when the bitmaps in a platform-canvas wasn't ref-countable. That is no longer the case (hasn't been true for quite a while AFAIK) so this CL removes that code. BUG= Review-Url: https://codereview.chromium.org/2799283003 Cr-Commit-Position: refs/heads/master@{#462845} Committed: https://chromium.googlesource.com/chromium/src/+/0551782d3e45a41949e2508c912acc7800cd4fad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -31 lines) Patch
M chrome/browser/thumbnails/content_based_thumbnailing_algorithm.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/thumbnails/simple_thumbnail_crop.cc View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
reed1
3 years, 8 months ago (2017-04-06 18:15:55 UTC) #3
reed1
3 years, 8 months ago (2017-04-06 18:17:13 UTC) #6
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-07 07:00:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799283003/1
3 years, 8 months ago (2017-04-07 12:32:59 UTC) #11
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 12:40:45 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0551782d3e45a41949e2508c912a...

Powered by Google App Engine
This is Rietveld 408576698