Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2799283002: [heap] Fix off-by-one cell read in verification methods (Closed)

Created:
3 years, 8 months ago by Michael Lippautz
Modified:
3 years, 8 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix off-by-one cell read in verification methods The actual value was always &-ed with 0 so technically correct. ASAN rightfully complains when allocating an external bitmap though. BUG=chromium:651354 R=ulan@chromium.org Review-Url: https://codereview.chromium.org/2799283002 Cr-Commit-Position: refs/heads/master@{#44453} Committed: https://chromium.googlesource.com/v8/v8/+/d265d3a274ee5766d370f3a977cc558099fbbd66

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -4 lines) Patch
M src/heap/marking.h View 2 chunks +14 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Michael Lippautz
3 years, 8 months ago (2017-04-06 15:10:12 UTC) #1
ulan
lgtm
3 years, 8 months ago (2017-04-06 16:08:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799283002/1
3 years, 8 months ago (2017-04-06 16:09:20 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 16:12:31 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d265d3a274ee5766d370f3a977cc558099f...

Powered by Google App Engine
This is Rietveld 408576698