components/favicon/core/favicon_driver_impl.h - Issue 2799273002: Add support to process favicons from Web Manifests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/favicon/core/favicon_driver_impl.h

Issue 2799273002: Add support to process favicons from Web Manifests (Closed)

Patch Set: Browsertest comments addressed. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/favicon/core/favicon_driver_impl.h

diff --git a/components/favicon/core/favicon_driver_impl.h b/components/favicon/core/favicon_driver_impl.h

index 1dd73112dbc8a69b177fe8ec83f687b4c61bb0cb..a64a9f313f2e71729a36c786837d1a57f481a953 100644

--- a/components/favicon/core/favicon_driver_impl.h

+++ b/components/favicon/core/favicon_driver_impl.h

@@ -60,7 +60,8 @@ class FaviconDriverImpl : public FaviconDriver,

// Broadcasts new favicon URL candidates to FaviconHandlers.

void OnUpdateCandidates(const GURL& page_url,

- const std::vector<FaviconURL>& candidates);

+ const std::vector<FaviconURL>& candidates,

+ const GURL& manifest_url);

protected:

history::HistoryService* history_service() { return history_service_; }