Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1625)

Side by Side Diff: components/favicon/core/favicon_driver_impl.h

Issue 2799273002: Add support to process favicons from Web Manifests (Closed)
Patch Set: Browsertest comments addressed. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_ 5 #ifndef COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_
6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_ 6 #define COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
53 bookmarks::BookmarkModel* bookmark_model); 53 bookmarks::BookmarkModel* bookmark_model);
54 ~FaviconDriverImpl() override; 54 ~FaviconDriverImpl() override;
55 55
56 // Informs FaviconService that the favicon for |url| is out of date. If 56 // Informs FaviconService that the favicon for |url| is out of date. If
57 // |force_reload| is true, then discard information about favicon download 57 // |force_reload| is true, then discard information about favicon download
58 // failures. 58 // failures.
59 void SetFaviconOutOfDateForPage(const GURL& url, bool force_reload); 59 void SetFaviconOutOfDateForPage(const GURL& url, bool force_reload);
60 60
61 // Broadcasts new favicon URL candidates to FaviconHandlers. 61 // Broadcasts new favicon URL candidates to FaviconHandlers.
62 void OnUpdateCandidates(const GURL& page_url, 62 void OnUpdateCandidates(const GURL& page_url,
63 const std::vector<FaviconURL>& candidates); 63 const std::vector<FaviconURL>& candidates,
64 const GURL& manifest_url);
64 65
65 protected: 66 protected:
66 history::HistoryService* history_service() { return history_service_; } 67 history::HistoryService* history_service() { return history_service_; }
67 68
68 FaviconService* favicon_service() { return favicon_service_; } 69 FaviconService* favicon_service() { return favicon_service_; }
69 70
70 private: 71 private:
71 // KeyedServices used by FaviconDriverImpl. They may be null during testing, 72 // KeyedServices used by FaviconDriverImpl. They may be null during testing,
72 // but if they are defined, they must outlive the FaviconDriverImpl. 73 // but if they are defined, they must outlive the FaviconDriverImpl.
73 FaviconService* favicon_service_; 74 FaviconService* favicon_service_;
74 history::HistoryService* history_service_; 75 history::HistoryService* history_service_;
75 bookmarks::BookmarkModel* bookmark_model_; 76 bookmarks::BookmarkModel* bookmark_model_;
76 77
77 // FaviconHandlers used to download the different kind of favicons. 78 // FaviconHandlers used to download the different kind of favicons.
78 std::vector<std::unique_ptr<FaviconHandler>> handlers_; 79 std::vector<std::unique_ptr<FaviconHandler>> handlers_;
79 80
80 DISALLOW_COPY_AND_ASSIGN(FaviconDriverImpl); 81 DISALLOW_COPY_AND_ASSIGN(FaviconDriverImpl);
81 }; 82 };
82 83
83 } // namespace favicon 84 } // namespace favicon
84 85
85 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_ 86 #endif // COMPONENTS_FAVICON_CORE_FAVICON_DRIVER_IMPL_H_
OLDNEW
« no previous file with comments | « components/favicon/content/content_favicon_driver.cc ('k') | components/favicon/core/favicon_driver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698