Add flag for zip archiver on files app.

Add flag for zip archiver on files app.

This CL just adds a flags for zip archiver, a new chrome extension for
files app.

BUG=706851
Review-Url: https://codereview.chromium.org/2799233002
Cr-Commit-Position: refs/heads/master@{#462761}
Committed: https://chromium.googlesource.com/chromium/src/+/183b8cb430ef80e40afc4b4659f77f5832075b2d

[takise, 2017-04-06 11:09:48]

Description was changed from

==========
Add flag for zip archiver on files app.

This CL just adds a flags for zip archiver, a new chrome extension for
files app.

BUG=
==========

to

==========
Add flag for zip archiver on files app.

This CL just adds a flags for zip archiver, a new chrome extension for
files app.

BUG=
==========

[takise, 2017-04-06 11:09:48]

takise@google.com changed reviewers:
+ isherman@chromium.org, yawano@chromium.org

[takise, 2017-04-06 11:10:01]

PTAL, thanks!

[yawano, 2017-04-06 11:22:13]

yawano@chromium.org changed reviewers:
+ weifangsun@chromium.org

[yawano, 2017-04-06 11:22:14]

Mostly looks good.

Please add bug number. We have a bug at https://crbug.com/706851.

weifangsun@: PTAL flag name and flag description. You can check it at
https://codereview.chromium.org/2799233002/diff/1/chrome/browser/flag_descrip...

https://codereview.chromium.org/2799233002/diff/1/chrome/browser/flag_descrip...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2799233002/diff/1/chrome/browser/flag_descrip...
chrome/browser/flag_descriptions.cc:2274: "Enables zipping on Files app";
Zipping is already available on Files app. Might be better to provide more
descriptive one, such as "Use zip archiver to zip files in Files app", etc.

https://codereview.chromium.org/2799233002/diff/1/chrome/browser/flag_descrip...
File chrome/browser/flag_descriptions.h (right):

https://codereview.chromium.org/2799233002/diff/1/chrome/browser/flag_descrip...
chrome/browser/flag_descriptions.h:2467: // Name of zip archiver on files app.
small nit: "Name of zip archiver on files app flag." to make consistent with
other comments. Same with the comment of description.

[chromium-reviews, 2017-04-06 16:54:15]

Please see my suggestion below -

Flag Name: "ZIP archiver for Drive"
Flag Description: "Enable the ability to archive and unpack files on Drive
in the Files app"

Let me know if you have any comments!

Thanks,
Weifang

On Thu, Apr 6, 2017 at 4:22 AM, <yawano@chromium.org> wrote:

> Mostly looks good.
>
> Please add bug number. We have a bug at https://crbug.com/706851.
>
> weifangsun@: PTAL flag name and flag description. You can check it at
> https://codereview.chromium.org/2799233002/diff/1/chrome/bro
> wser/flag_descriptions.cc
>
>
> https://codereview.chromium.org/2799233002/diff/1/chrome/bro
> wser/flag_descriptions.cc
> File chrome/browser/flag_descriptions.cc (right):
>
> https://codereview.chromium.org/2799233002/diff/1/chrome/bro
> wser/flag_descriptions.cc#newcode2274
> chrome/browser/flag_descriptions.cc:2274: "Enables zipping on Files
> app";
> Zipping is already available on Files app. Might be better to provide
> more descriptive one, such as "Use zip archiver to zip files in Files
> app", etc.
>
> https://codereview.chromium.org/2799233002/diff/1/chrome/bro
> wser/flag_descriptions.h
> File chrome/browser/flag_descriptions.h (right):
>
> https://codereview.chromium.org/2799233002/diff/1/chrome/bro
> wser/flag_descriptions.h#newcode2467
> chrome/browser/flag_descriptions.h:2467: // Name of zip archiver on
> files app.
> small nit: "Name of zip archiver on files app flag." to make consistent
> with other comments. Same with the comment of description.
>
> https://codereview.chromium.org/2799233002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Ilya Sherman, 2017-04-06 22:05:43]

histograms.xml lgtm

[takise, 2017-04-07 00:54:49]

Description was changed from

==========
Add flag for zip archiver on files app.

This CL just adds a flags for zip archiver, a new chrome extension for
files app.

BUG=
==========

to

==========
Add flag for zip archiver on files app.

This CL just adds a flags for zip archiver, a new chrome extension for
files app.

BUG=706851
==========

[takise, 2017-04-07 00:55:33]

Modified the name and description. Please take a look again, thanks!

[yawano, 2017-04-07 01:14:48]

lgtm with a very small nit. Thank you!

https://codereview.chromium.org/2799233002/diff/20001/chrome/browser/flag_des...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2799233002/diff/20001/chrome/browser/flag_des...
chrome/browser/flag_descriptions.cc:2274: "Enable the ability to archive and
unpack files on Drive "
very small nit: Please use up 80 characters before you go to the next line.

[takise, 2017-04-07 01:20:04]

The CQ bit was checked by takise@google.com

[takise, 2017-04-07 01:20:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/2799233002/#ps40001
(title: "Fixed a small nit.")

[commit-bot: I haz the power, 2017-04-07 01:20:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 01:23:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 01:23:14]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[takise, 2017-04-07 01:35:10]

The CQ bit was checked by takise@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-04-07 01:35:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 03:37:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 03:37:31]

Dry run: This issue passed the CQ dry run.

[takise, 2017-04-07 04:33:29]

The CQ bit was checked by takise@google.com

[takise, 2017-04-07 04:33:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, yawano@chromium.org
Link to the patchset: https://codereview.chromium.org/2799233002/#ps60001
(title: "Resolved conflict with master.")

[commit-bot: I haz the power, 2017-04-07 04:34:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-07 05:12:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1491539609367980,
"parent_rev": "c3af7fa4c410ee0ca5c6b4607487475dd8e32ab8", "commit_rev":
"183b8cb430ef80e40afc4b4659f77f5832075b2d"}

[commit-bot: I haz the power, 2017-04-07 05:13:04]

Description was changed from

==========
Add flag for zip archiver on files app.

This CL just adds a flags for zip archiver, a new chrome extension for
files app.

BUG=706851
==========

to

==========
Add flag for zip archiver on files app.

This CL just adds a flags for zip archiver, a new chrome extension for
files app.

BUG=706851

Review-Url: https://codereview.chromium.org/2799233002
Cr-Commit-Position: refs/heads/master@{#462761}
Committed:
https://chromium.googlesource.com/chromium/src/+/183b8cb430ef80e40afc4b4659f7...
==========

[commit-bot: I haz the power, 2017-04-07 05:13:05]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/183b8cb430ef80e40afc4b4659f7...