Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2799223002: Add CHECKs to investigate crashes in BytesConsumerForDataConsumerHandle (Closed)

Created:
3 years, 8 months ago by yhirano
Modified:
3 years, 8 months ago
Reviewers:
hiroshige
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add CHECKs to investigate crashes in BytesConsumerForDataConsumerHandle This CL adds some CHECKs to see if our assumptions on SharedMemoryDataConsumerHandle hold. BUG=704863 R=hiroshige@chromium.org Review-Url: https://codereview.chromium.org/2799223002 Cr-Commit-Position: refs/heads/master@{#463335} Committed: https://chromium.googlesource.com/chromium/src/+/493381c78470da5e8e3cef83b1859b95b8008a73

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M content/child/shared_memory_data_consumer_handle.cc View 1 2 3 3 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
yhirano
3 years, 8 months ago (2017-04-06 12:15:20 UTC) #11
hiroshige
lgtm
3 years, 8 months ago (2017-04-10 17:15:00 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799223002/60001
3 years, 8 months ago (2017-04-10 17:15:35 UTC) #14
commit-bot: I haz the power
3 years, 8 months ago (2017-04-10 18:28:31 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/493381c78470da5e8e3cef83b185...

Powered by Google App Engine
This is Rietveld 408576698