Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2799213002: Change BUILD.gn so that minizip can be built with NaCL toolchain. (Closed)

Created:
3 years, 8 months ago by takise
Modified:
3 years, 8 months ago
Reviewers:
msarett1
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change BUILD.gn so that minizip can be built with NaCL toolchain. MiniZip will be used by Zip Archiver, which is built with NaCL toolchain. MiniZip will be moved to src/third_party/ in the future, but it will take time, so now we just use minizip here. Review-Url: https://codereview.chromium.org/2799213002 Cr-Commit-Position: refs/heads/master@{#462779} Committed: https://chromium.googlesource.com/chromium/src/+/3387639806215545d562fa99b93054a6754779b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/zlib/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
takise
PTAL. Thanks!
3 years, 8 months ago (2017-04-06 08:32:04 UTC) #3
msarett1
lgtm
3 years, 8 months ago (2017-04-06 12:59:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799213002/1
3 years, 8 months ago (2017-04-07 00:59:02 UTC) #6
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 05:49:29 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3387639806215545d562fa99b930...

Powered by Google App Engine
This is Rietveld 408576698