Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2799203003: [ios] Fix warning when running "gn gen". (Closed)

Created:
3 years, 8 months ago by sdefresne
Modified:
3 years, 8 months ago
Reviewers:
stkhapugin
CC:
chromium-reviews, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios] Fix warning when running "gn gen". Fix the following warning (incorrectly labelled as an error): ERROR at //.gn:44:25: Build argument has no effect. v8_enable_inspector = true ^--- The variable "v8_enable_inspector" was set as a build argument but never appeared in a declare_args() block in any buildfile. BUG=684096 Review-Url: https://codereview.chromium.org/2799203003 Cr-Commit-Position: refs/heads/master@{#462476} Committed: https://chromium.googlesource.com/chromium/src/+/7ce21e2df98546eb664d6cbcd11a592d1599dd48

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
sdefresne
Please take a look.
3 years, 8 months ago (2017-04-06 14:00:31 UTC) #4
stkhapugin
lgtm
3 years, 8 months ago (2017-04-06 14:00:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799203003/1
3 years, 8 months ago (2017-04-06 14:01:17 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 15:16:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7ce21e2df98546eb664d6cbcd11a...

Powered by Google App Engine
This is Rietveld 408576698