Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2799163003: MD Settings: Bluetooth: Hide subpage arrow when disabled and fix string (Closed)

Created:
3 years, 8 months ago by stevenjb
Modified:
3 years, 8 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Bluetooth: Hide subpage arrow when disabled This CL: * Hides the subpage arrow when Bluetooth is disconnected. * Fixes the dropdown text to 'Connect' for paired but disconnected BUG=709079, 705682 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2799163003 Cr-Commit-Position: refs/heads/master@{#462714} Committed: https://chromium.googlesource.com/chromium/src/+/dc776ed82432f7205b2ab12f7c1da137faaf6628

Patch Set 1 #

Patch Set 2 : Fix connect string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/browser/resources/settings/bluetooth_page/bluetooth_device_list_item.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/bluetooth_page/bluetooth_page.html View 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
stevenjb
3 years, 8 months ago (2017-04-06 17:25:43 UTC) #4
Dan Beam
note: we've undone the "hide the subpage arrow when feature is disable" where feature = ...
3 years, 8 months ago (2017-04-06 17:27:22 UTC) #6
stevenjb
On 2017/04/06 17:27:22, Dan Beam wrote: > note: we've undone the "hide the subpage arrow ...
3 years, 8 months ago (2017-04-06 17:33:36 UTC) #7
michaelpg
lgtm
3 years, 8 months ago (2017-04-06 22:47:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799163003/20001
3 years, 8 months ago (2017-04-06 23:03:34 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 00:44:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dc776ed82432f7205b2ab12f7c1d...

Powered by Google App Engine
This is Rietveld 408576698