enhance analyzer to parse uppercase and built-in/pseudo keywords

pkg/analyzer/lib/src/generated/error_verifier.dart

Index: pkg/analyzer/lib/src/generated/error_verifier.dart
diff --git a/pkg/analyzer/lib/src/generated/error_verifier.dart b/pkg/analyzer/lib/src/generated/error_verifier.dart
index 98afc2e39a70d4d78ea8d238f9526013c6e8ee6d..1d1cb03d0682ca3949de6c777b08d13e50b326bb 100644
--- a/pkg/analyzer/lib/src/generated/error_verifier.dart
+++ b/pkg/analyzer/lib/src/generated/error_verifier.dart
@@ -2627,7 +2627,7 @@ class ErrorVerifier extends RecursiveAstVisitor<Object> {
   void _checkForBuiltInIdentifierAsName(
       SimpleIdentifier identifier, ErrorCode errorCode) {
     Token token = identifier.token;
-    if (token.type == TokenType.KEYWORD) {
+    if (token.type == TokenType.KEYWORD && token.keyword?.isPseudo != true) {

[Paul Berry, 2017/04/06 17:09:49]

Since token.keyword is non-null if and only if token.type == TokenType.KEYWORD,
I think we could simplify this to:

if (token.keyword?.isPseudo != true)

[danrubel, 2017/04/06 19:21:35]

Unfortunately that change will report errors on any token that returns a null
keyword, such as all identifiers. That said, you have a good point that this
expression could probably be simplified.

       _errorReporter
           .reportErrorForNode(errorCode, identifier, [identifier.name]);
     }