Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2799113003:
Remove |auth_controllers_| a dead field in HttpStreamFactoryImpl::Job (Closed)
DescriptionRemove |auth_controllers_| a dead field in HttpStreamFactoryImpl::Job
BUG=475060
Review-Url: https://codereview.chromium.org/2799113003
Cr-Commit-Position: refs/heads/master@{#462754}
Committed: https://chromium.googlesource.com/chromium/src/+/4b2378f60756cfec7f62b54d3d98208382474b88
Patch Set 1 #Patch Set 2 : rebased #Messages
Total messages: 17 (11 generated)
xunjieli@chromium.org changed reviewers: + bnc@chromium.org
The CQ bit was checked by xunjieli@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by bnc@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for net/http/http_stream_factory_impl_job.h:
While running git apply --index -3 -p1;
error: patch failed: net/http/http_stream_factory_impl_job.h:452
Falling back to three-way merge...
Applied patch to 'net/http/http_stream_factory_impl_job.h' with conflicts.
U net/http/http_stream_factory_impl_job.h
Patch: net/http/http_stream_factory_impl_job.h
Index: net/http/http_stream_factory_impl_job.h
diff --git a/net/http/http_stream_factory_impl_job.h
b/net/http/http_stream_factory_impl_job.h
index
0ae7222b79239c2f25219d91a8f6a3eb125b4a5d..d05f5560ccb09e2ef26835f9c61cac56bb0da600
100644
--- a/net/http/http_stream_factory_impl_job.h
+++ b/net/http/http_stream_factory_impl_job.h
@@ -452,9 +452,6 @@ class HttpStreamFactoryImpl::Job {
// Force quic for a specific port.
int force_quic_port_;
- scoped_refptr<HttpAuthController>
- auth_controllers_[HttpAuth::AUTH_NUM_TARGETS];
-
// True when the tunnel is in the process of being established - we can't
// read from the socket until the tunnel is done.
bool establishing_tunnel_;
The CQ bit was checked by xunjieli@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from bnc@chromium.org Link to the patchset: https://codereview.chromium.org/2799113003/#ps20001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491525896343590,
"parent_rev": "77744550580e6f83fa1ada19e8f96722b911640f", "commit_rev":
"4b2378f60756cfec7f62b54d3d98208382474b88"}
Message was sent while issue was closed.
Description was changed from ========== Remove |auth_controllers_| a dead field in HttpStreamFactoryImpl::Job BUG=475060 ========== to ========== Remove |auth_controllers_| a dead field in HttpStreamFactoryImpl::Job BUG=475060 Review-Url: https://codereview.chromium.org/2799113003 Cr-Commit-Position: refs/heads/master@{#462754} Committed: https://chromium.googlesource.com/chromium/src/+/4b2378f60756cfec7f62b54d3d98... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/4b2378f60756cfec7f62b54d3d98... |
