Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2799093003: Reland of moving duplicate functions and symbol names in core/css (Closed)

Created:
3 years, 8 months ago by Guido Urdaneta
Modified:
3 years, 8 months ago
Reviewers:
Daniel Bratell, rune
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of moving duplicate functions and symbol names in core/css (patchset #1 id:1 of https://codereview.chromium.org/2801683005/ ) Reason for revert: The revert did not fix the failing bot, so relanding. Original issue's description: > Revert of Removing duplicate functions and symbol names in core/css (patchset #2 id:20001 of https://codereview.chromium.org/2797973002/ ) > > Reason for revert: > This is a speculative revert to determine if this is causing a WebRTC Chrome bot to fail. > > See > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Android%20Tests%20%28dbg%29%20%28L%20Nexus6%29/builds/14774 > > If the revert does not fix the bot, I will reland. > > Original issue's description: > > Removing duplicate functions and symbol names in core/css > > > > In the unity build experiment I encountered a few colliding duplicate > > symbol names in core/css and this patch removes them by replacing > > duplicated symbols with a single code and by doing some symbol > > renames. > > > > Review-Url: https://codereview.chromium.org/2797973002 > > Cr-Commit-Position: refs/heads/master@{#462256} > > Committed: https://chromium.googlesource.com/chromium/src/+/5fa4cb0d7a1a784fec7991eaeb1a80e43f9156e5 > > TBR=rune@opera.com,bratell@opera.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Review-Url: https://codereview.chromium.org/2801683005 > Cr-Commit-Position: refs/heads/master@{#462394} > Committed: https://chromium.googlesource.com/chromium/src/+/13f391f98453cf27e1f355c27982969a9745eb1b TBR=rune@opera.com,bratell@opera.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2799093003 Cr-Commit-Position: refs/heads/master@{#462405} Committed: https://chromium.googlesource.com/chromium/src/+/7d2f2a94dcea8910c419b6afca5e1c9cf5329cd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M third_party/WebKit/Source/core/css/CSSComputedStyleDeclaration.cpp View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.h View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp View 2 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
A third_party/WebKit/Source/core/css/zoomAdjustedPixelValue.h View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Guido Urdaneta
Created Reland of moving duplicate functions and symbol names in core/css
3 years, 8 months ago (2017-04-06 09:49:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799093003/1
3 years, 8 months ago (2017-04-06 09:50:17 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 09:52:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d2f2a94dcea8910c419b6afca5e...

Powered by Google App Engine
This is Rietveld 408576698