Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2799093002: s/DidNavigateWithinPage/OnSameDocumentNavigation. (Closed)

Created:
3 years, 8 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 8 months ago
CC:
chromium-reviews, darin-cc_chromium.org, grt+watch_chromium.org, jam, timvolodine, vakh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

s/DidNavigateWithinPage/OnSameDocumentNavigation. Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. BUG=695189 Review-Url: https://codereview.chromium.org/2799093002 Cr-Commit-Position: refs/heads/master@{#462490} Committed: https://chromium.googlesource.com/chromium/src/+/ee24cb324ef34572a83f4d81d8af11f91b59d378

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M chrome/renderer/content_settings_observer_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate_browsertest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/test/render_view_test.h View 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/test/render_view_test.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
PTAL
3 years, 8 months ago (2017-04-05 22:41:31 UTC) #4
jochen (gone - plz use gerrit)
lgtm
3 years, 8 months ago (2017-04-06 09:59:44 UTC) #7
Eugene But (OOO till 7-30)
Thanks for a quick review!
3 years, 8 months ago (2017-04-06 15:25:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799093002/1
3 years, 8 months ago (2017-04-06 15:26:33 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 15:44:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ee24cb324ef34572a83f4d81d8af...

Powered by Google App Engine
This is Rietveld 408576698