Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2799083004: Implements ApplyTranslateOptions in compact infobar (Closed)
Patch Set: a Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
index 72213bcdd6b402515fd261ecba2edcb8fa60fe65..aaff5313f0611a5362c60da1a8bb373707ffac66 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java
@@ -93,5 +93,6 @@ class TranslateCompactInfoBar extends InfoBar implements TabLayout.OnTabSelected
@Override
public void onTabReselected(TabLayout.Tab tab) {}
- private native void nativeApplyTranslateOptions(long nativeTranslateCompactInfoBar);
+ private native void nativeApplyTranslateOptions(
+ long nativeTranslateCompactInfoBar, int option, String value);
gone 2017/04/11 17:32:36 JNI calls are expensive -- especially if you're pa
ramyasharma 2017/04/12 00:36:40 1. In the current code, 5 parameters are passed in
gone 2017/04/12 00:39:27 I'm fine with a single parameter thing, but you sh
}

Powered by Google App Engine
This is Rietveld 408576698