Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateCompactInfoBar.java

Issue 2799083004: Implements ApplyTranslateOptions in compact infobar (Closed)
Patch Set: a Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.infobar; 5 package org.chromium.chrome.browser.infobar;
6 6
7 import android.support.design.widget.TabLayout; 7 import android.support.design.widget.TabLayout;
8 import android.view.LayoutInflater; 8 import android.view.LayoutInflater;
9 import android.widget.LinearLayout; 9 import android.widget.LinearLayout;
10 10
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 onButtonClicked(ActionType.TRANSLATE); 86 onButtonClicked(ActionType.TRANSLATE);
87 } 87 }
88 } 88 }
89 89
90 @Override 90 @Override
91 public void onTabUnselected(TabLayout.Tab tab) {} 91 public void onTabUnselected(TabLayout.Tab tab) {}
92 92
93 @Override 93 @Override
94 public void onTabReselected(TabLayout.Tab tab) {} 94 public void onTabReselected(TabLayout.Tab tab) {}
95 95
96 private native void nativeApplyTranslateOptions(long nativeTranslateCompactI nfoBar); 96 private native void nativeApplyTranslateOptions(
97 long nativeTranslateCompactInfoBar, int option, String value);
gone 2017/04/11 17:32:36 JNI calls are expensive -- especially if you're pa
ramyasharma 2017/04/12 00:36:40 1. In the current code, 5 parameters are passed in
gone 2017/04/12 00:39:27 I'm fine with a single parameter thing, but you sh
97 } 98 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698