Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2799043003: Revert of Pref service: add support for tracked prefs. (Closed)

Created:
3 years, 8 months ago by foolip
Modified:
3 years, 8 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, droger+watchlist_chromium.org, viettrungluu+watch_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), chrome-apps-syd-reviews_chromium.org, gab
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Pref service: add support for tracked prefs. (patchset #19 id:570001 of https://codereview.chromium.org/2745563005/ ) Reason for revert: ProfilePrefStoreManagerTest/ProfilePrefStoreManagerTest.UnprotectedToProtected/1 became flaky shortly after this landed. BUG=708901 Original issue's description: > Pref service: add support for tracked prefs. > > This: > - Adds TrackedPersistentPrefStoreConfiguration: a mojo struct containing > the necessary state for constructing a PrefStore identical to the one > constructed in ProfilePrefStoreManager::CreateProfilePrefStore(). > - Moves the enums used to configure tracked prefs into the mojom. > - Extracts the creation of tracked pref store from > ProfilePrefStoreManager::CreateProfilePrefStore() into > prefs::CreateTrackedPersistentPrefStore(). > - Changes prefs::CreatePersistentPrefStore() so an appropriate > configuration results in prefs::CreateTrackedPersistentPrefStore() > being called to create the backing PrefStore. > > BUG=654988 > > Review-Url: https://codereview.chromium.org/2745563005 > Cr-Commit-Position: refs/heads/master@{#462301} > Committed: https://chromium.googlesource.com/chromium/src/+/d2e2fed00150274e4a6857c700dcb24f99793bd7 TBR=tibell@chromium.org,bauerb@chromium.org,mbarbella@chromium.org,gab@chromium.org,mlerman@chromium.org,sammc@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=654988 Review-Url: https://codereview.chromium.org/2799043003 Cr-Commit-Position: refs/heads/master@{#462374} Committed: https://chromium.googlesource.com/chromium/src/+/3014f8b41e775fcbdc8fbc1e5b4bd7cb0bfd3100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -421 lines) Patch
M chrome/browser/prefs/chrome_pref_service_factory.h View 4 chunks +9 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 6 chunks +18 lines, -37 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.h View 4 chunks +51 lines, -36 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager.cc View 6 chunks +124 lines, -65 lines 0 comments Download
M chrome/browser/prefs/profile_pref_store_manager_unittest.cc View 16 chunks +42 lines, -43 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 3 chunks +2 lines, -8 lines 0 comments Download
M services/preferences/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M services/preferences/persistent_pref_store_factory.cc View 3 chunks +1 line, -8 lines 0 comments Download
M services/preferences/persistent_pref_store_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M services/preferences/persistent_pref_store_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M services/preferences/persistent_pref_store_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/preferences/public/interfaces/preferences_configuration.mojom View 2 chunks +0 lines, -22 lines 0 comments Download
M services/preferences/tracked/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M services/preferences/tracked/pref_hash_filter.h View 3 chunks +5 lines, -5 lines 0 comments Download
M services/preferences/tracked/pref_hash_filter.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M services/preferences/tracked/pref_hash_filter_unittest.cc View 4 chunks +3 lines, -11 lines 0 comments Download
M services/preferences/tracked/segregated_pref_store.h View 3 chunks +1 line, -8 lines 0 comments Download
M services/preferences/tracked/segregated_pref_store.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M services/preferences/tracked/segregated_pref_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D services/preferences/tracked/tracked_persistent_pref_store_factory.h View 1 chunk +0 lines, -27 lines 0 comments Download
D services/preferences/tracked/tracked_persistent_pref_store_factory.cc View 1 chunk +0 lines, -133 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
foolip
Created Revert of Pref service: add support for tracked prefs.
3 years, 8 months ago (2017-04-06 06:26:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2799043003/1
3 years, 8 months ago (2017-04-06 06:29:56 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-06 06:36:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3014f8b41e775fcbdc8fbc1e5b4b...

Powered by Google App Engine
This is Rietveld 408576698