Resume() should return if context is already running

Resume() should return if context is already running

It's valid to call AudioContext.resume() if the context is already
running.  The promise should resolve immediately; we can handle the
promise now instead of saving it on a list to be resolved later.  This
prevents us from setting the context state to running again when it's
already running, because that triggers a DCHECK.

The spedc also says to resolve the promise when the context is already
running.

BUG=707949
TEST=audiocontext-suspend-resume.html

Review-Url: https://codereview.chromium.org/2798973002
Cr-Commit-Position: refs/heads/master@{#462506}
Committed: https://chromium.googlesource.com/chromium/src/+/5149859e198b741fe8c89a165e4035339efcdb62

[Raymond Toy, 2017-04-05 18:26:45]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-04-05 18:26:45]

PTAL

[hongchan, 2017-04-05 21:44:42]

lgtm with nit

https://codereview.chromium.org/2798973002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html
(right):

https://codereview.chromium.org/2798973002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html:126:
"Create online context")
Let's not mix single and double quote. We should use the single quote only.

[Raymond Toy, 2017-04-05 21:53:48]

https://codereview.chromium.org/2798973002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html
(right):

https://codereview.chromium.org/2798973002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioContext/audiocontext-suspend-resume.html:126:
"Create online context")
On 2017/04/05 21:44:42, hongchan wrote:
> Let's not mix single and double quote. We should use the single quote only.

Too much c++.

[Raymond Toy, 2017-04-05 21:56:18]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-04-05 21:56:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2798973002/#ps20001
(title: "Address review comments.")

[commit-bot: I haz the power, 2017-04-05 21:57:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-05 22:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-05 22:04:42]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Raymond Toy, 2017-04-06 15:29:12]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-04-06 15:29:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-06 16:42:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1491492552128260,
"parent_rev": "995a4c3eb2d2c8540a3685fb761b675e65fb40f4", "commit_rev":
"5149859e198b741fe8c89a165e4035339efcdb62"}

[commit-bot: I haz the power, 2017-04-06 16:44:07]

Description was changed from

==========
Resume() should return if context is already running

It's valid to call AudioContext.resume() if the context is already
running.  The promise should resolve immediately; we can handle the
promise now instead of saving it on a list to be resolved later.  This
prevents us from setting the context state to running again when it's
already running, because that triggers a DCHECK.

The spedc also says to resolve the promise when the context is already
running.

BUG=707949
TEST=audiocontext-suspend-resume.html
==========

to

==========
Resume() should return if context is already running

It's valid to call AudioContext.resume() if the context is already
running.  The promise should resolve immediately; we can handle the
promise now instead of saving it on a list to be resolved later.  This
prevents us from setting the context state to running again when it's
already running, because that triggers a DCHECK.

The spedc also says to resolve the promise when the context is already
running.

BUG=707949
TEST=audiocontext-suspend-resume.html

Review-Url: https://codereview.chromium.org/2798973002
Cr-Commit-Position: refs/heads/master@{#462506}
Committed:
https://chromium.googlesource.com/chromium/src/+/5149859e198b741fe8c89a165e40...
==========

[commit-bot: I haz the power, 2017-04-06 16:44:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5149859e198b741fe8c89a165e40...