Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2798963002: Remove unused code (Closed)

Created:
3 years, 8 months ago by gambard
Modified:
3 years, 8 months ago
Reviewers:
lpromero
CC:
chromium-reviews, ios-reviews+chrome_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused code Remove some unused code in ContentSuggestions. This code was added when more type of suggestions were planned. BUG=694159 Review-Url: https://codereview.chromium.org/2798963002 Cr-Commit-Position: refs/heads/master@{#462110} Committed: https://chromium.googlesource.com/chromium/src/+/e7cde9afc4a89a78efb266e835c06b6d637ee75c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1301 lines) Patch
M ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M ios/chrome/browser/content_suggestions/mediator_util.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/cells/BUILD.gn View 2 chunks +0 lines, -17 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item.mm View 1 chunk +0 lines, -97 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item_actions.h View 1 chunk +0 lines, -18 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_button_item_unittest.mm View 1 chunk +0 lines, -31 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item.h View 1 chunk +0 lines, -58 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item.mm View 1 chunk +0 lines, -237 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_expandable_item_unittest.mm View 1 chunk +0 lines, -108 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_internal_cell.h View 1 chunk +0 lines, -20 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_internal_cell.mm View 1 chunk +0 lines, -70 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item.mm View 1 chunk +0 lines, -142 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_favicon_item_unittest.mm View 1 chunk +0 lines, -95 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item.h View 1 chunk +0 lines, -33 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item.mm View 1 chunk +0 lines, -143 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item_actions.h View 1 chunk +0 lines, -16 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_stack_item_unittest.mm View 1 chunk +0 lines, -31 lines 0 comments Download
D ios/chrome/browser/ui/content_suggestions/cells/expandable_item.h View 1 chunk +0 lines, -18 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_updater.mm View 4 chunks +2 lines, -14 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_commands.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.h View 2 chunks +1 line, -5 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm View 4 chunks +1 line, -57 lines 0 comments Download
M ios/chrome/browser/ui/content_suggestions/identifier/content_suggestion_identifier_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ui/content_suggestions/identifier/content_suggestions_section_information.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
gambard
PTAL.
3 years, 8 months ago (2017-04-05 15:23:52 UTC) #2
lpromero
lgtm :S
3 years, 8 months ago (2017-04-05 16:19:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2798963002/1
3 years, 8 months ago (2017-04-05 16:20:04 UTC) #8
commit-bot: I haz the power
3 years, 8 months ago (2017-04-05 16:40:08 UTC) #11
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e7cde9afc4a89a78efb266e835c0...

Powered by Google App Engine
This is Rietveld 408576698