chrome/browser/page_load_metrics/page_load_tracker.h - Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.h

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)

Patch Set: Address comments from PS17 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/page_load_metrics/page_load_tracker.h

diff --git a/chrome/browser/page_load_metrics/page_load_tracker.h b/chrome/browser/page_load_metrics/page_load_tracker.h

index 2760b014c2ed1f689010ca5ea55c4c8d576fa37e..0c1a1c19bcf2e8d6b5b0f4b4ca2858f2a3fae37b 100644

--- a/chrome/browser/page_load_metrics/page_load_tracker.h

+++ b/chrome/browser/page_load_metrics/page_load_tracker.h

@@ -202,6 +202,8 @@ class PageLoadTracker {

void WillProcessNavigationResponse(

content::NavigationHandle* navigation_handle);

void Commit(content::NavigationHandle* navigation_handle);

+ void DidFinishSubFrameNavigation(

+ content::NavigationHandle* navigation_handle);

void FailedProvisionalLoad(content::NavigationHandle* navigation_handle,

base::TimeTicks failed_load_time);

void WebContentsHidden();