Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Unified Diff: chrome/browser/page_load_metrics/page_load_metrics_observer.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Address comments from PS17 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/page_load_metrics_observer.cc
diff --git a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
index e3f395a76749b8407eb56587474972f5af713dc9..f37b0448f332817a38b15cf8e34664789bb40367 100644
--- a/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
+++ b/chrome/browser/page_load_metrics/page_load_metrics_observer.cc
@@ -57,12 +57,16 @@ PageLoadExtraInfo PageLoadExtraInfo::CreateForTesting(
}
ExtraRequestInfo::ExtraRequestInfo(
+ const GURL& url,
+ int frame_tree_node_id,
bool was_cached,
int64_t raw_body_bytes,
int64_t original_network_content_length,
std::unique_ptr<data_reduction_proxy::DataReductionProxyData>
data_reduction_proxy_data)
- : was_cached(was_cached),
+ : url(url),
+ frame_tree_node_id(frame_tree_node_id),
+ was_cached(was_cached),
raw_body_bytes(raw_body_bytes),
original_network_content_length(original_network_content_length),
data_reduction_proxy_data(std::move(data_reduction_proxy_data)) {}
@@ -92,6 +96,12 @@ PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnCommit(
return CONTINUE_OBSERVING;
}
+PageLoadMetricsObserver::ObservePolicy
+PageLoadMetricsObserver::OnDidFinishSubFrameNavigation(
+ content::NavigationHandle* navigation_handle) {
+ return CONTINUE_OBSERVING;
+}
+
PageLoadMetricsObserver::ObservePolicy PageLoadMetricsObserver::OnHidden(
const PageLoadTiming& timing,
const PageLoadExtraInfo& extra_info) {

Powered by Google App Engine
This is Rietveld 408576698