Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3455)

Unified Diff: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc

Issue 2798953002: [PageLoadMetrics] Keep track of Ad Sizes on Pages (Closed)
Patch Set: Updates and address Ojan's comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
diff --git a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
index f109f3b265cb5639ef4da4e470bc2c73ed91c87d..7563be8210f3bcf63a54c9bf2603293515a950a5 100644
--- a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
+++ b/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
@@ -411,12 +411,12 @@ TEST_F(CorePageLoadMetricsObserverTest, Reload) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
0 /* original_network_content_length */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
1024 * 40 /* original_network_content_length */},
};
@@ -496,12 +496,12 @@ TEST_F(CorePageLoadMetricsObserverTest, ForwardBack) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
0 /* original_network_content_length */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
1024 * 40 /* original_network_content_length */},
};
@@ -575,12 +575,12 @@ TEST_F(CorePageLoadMetricsObserverTest, NewNavigation) {
page_load_metrics::ExtraRequestInfo resources[] = {
// Cached request.
- {true /*was_cached*/, 1024 * 20 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, true /*was_cached*/,
+ 1024 * 20 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
0 /* original_network_content_length */},
// Uncached non-proxied request.
- {false /*was_cached*/, 1024 * 40 /* raw_body_bytes */,
- false /* data_reduction_proxy_used*/,
+ {GURL(), -1 /* frame_tree_node_id */, false /*was_cached*/,
+ 1024 * 40 /* raw_body_bytes */, false /* data_reduction_proxy_used*/,
1024 * 40 /* original_network_content_length */},
};

Powered by Google App Engine
This is Rietveld 408576698